Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync with aeserialization #1622

Merged
merged 6 commits into from
Jul 26, 2022
Merged

Sync with aeserialization #1622

merged 6 commits into from
Jul 26, 2022

Conversation

davidyuk
Copy link
Member

@davidyuk davidyuk commented Jul 26, 2022

@codecov
Copy link

codecov bot commented Jul 26, 2022

Codecov Report

Merging #1622 (764661d) into develop (34c4a59) will increase coverage by 0.56%.
The diff coverage is 97.04%.

❗ Current head 764661d differs from pull request most recent head 2b25e5d. Consider uploading reports for the commit 2b25e5d to get more accurate results

@@             Coverage Diff             @@
##           develop    #1622      +/-   ##
===========================================
+ Coverage    82.65%   83.21%   +0.56%     
===========================================
  Files           62       64       +2     
  Lines         2969     3069     +100     
  Branches       540      546       +6     
===========================================
+ Hits          2454     2554     +100     
  Misses         302      302              
  Partials       213      213              
Impacted Files Coverage Δ
src/AeSdkWallet.ts 84.15% <ø> (ø)
src/Node.ts 95.45% <ø> (ø)
src/account/Rpc.ts 68.75% <ø> (ø)
src/aepp-wallet-communication/rpc/types.ts 100.00% <ø> (ø)
src/aepp-wallet-communication/schema.ts 85.39% <ø> (ø)
src/deprecated/methods.ts 60.00% <ø> (ø)
src/tx/builder/index.ts 69.46% <80.95%> (+1.21%) ⬆️
src/tx/builder/address.ts 81.25% <81.25%> (ø)
src/tx/builder/helpers.ts 91.37% <92.30%> (+3.31%) ⬆️
src/tx/validator.ts 86.84% <93.75%> (+0.17%) ⬆️
... and 28 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34c4a59...2b25e5d. Read the comment docs.

@davidyuk davidyuk marked this pull request as ready for review July 26, 2022 12:57
@davidyuk davidyuk merged commit 7be2615 into develop Jul 26, 2022
@davidyuk davidyuk deleted the feature/serialization branch July 26, 2022 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant