Add support for react 18 #10
Draft
+464
−108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshwilsonvu
reviewed
Jun 7, 2024
| * Updates in the given callback are batched together and only trigger a single | ||
| * render. | ||
| */ | ||
| export async function batch<T>(fn: () => Promise<T>): Promise<T> { |
There was a problem hiding this comment.
just jumping in, FYI, React 18 now batches all updates, not just updates in event handlers. Might reduce the need for manual batching if it all boils down to setState calls
There was a problem hiding this comment.
batch in this context means deferring observer updates for a set of async operations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.