-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for react 18 #10
Draft
jemmyw
wants to merge
4
commits into
aha-app:main
Choose a base branch
from
jemmyw:react18
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,305 @@ | ||
/** | ||
* This is an updated version of the original react-easy-state view function | ||
*/ | ||
|
||
// MIT License | ||
// | ||
// Copyright (c) 2019 Miklos Bertalan | ||
// | ||
// Permission is hereby granted, free of charge, to any person obtaining a copy | ||
// of this software and associated documentation files (the "Software"), to deal | ||
// in the Software without restriction, including without limitation the rights | ||
// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell | ||
// copies of the Software, and to permit persons to whom the Software is | ||
// furnished to do so, subject to the following conditions: | ||
|
||
// The above copyright notice and this permission notice shall be included in all | ||
// copies or substantial portions of the Software. | ||
|
||
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR | ||
// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, | ||
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE | ||
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER | ||
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, | ||
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE | ||
// SOFTWARE. | ||
|
||
import { observe, unobserve } from '@nx-js/observer-util'; | ||
import React, { memo, useEffect, useMemo, useState } from 'react'; | ||
|
||
const COMPONENT = Symbol('owner component'); | ||
|
||
function isReactFunction<P>( | ||
component: React.ComponentType<P> | ||
): component is React.FC<P> | ((props: P) => React.ReactElement) { | ||
return !component.prototype?.isReactComponent; | ||
} | ||
|
||
type ReactComponent<T> = | ||
| React.ComponentClass<T, any> | ||
| React.FC<T> | ||
| ((props: T) => React.ReactElement); | ||
|
||
class ViewUpdateEmitter { | ||
private static _batching = false; | ||
private static _immediate = false; | ||
static instances: WeakRef<ViewUpdateEmitter>[] = []; | ||
static batchedInstances: WeakRef<ViewUpdateEmitter>[] = []; | ||
|
||
static reset() { | ||
this.resolveBatches(); | ||
this._batching = false; | ||
this._immediate = false; | ||
} | ||
|
||
static set immediate(value: boolean) { | ||
if (value && this.batching) | ||
throw new Error('Cannot set immediate while batching'); | ||
this._immediate = value; | ||
} | ||
static get immediate() { | ||
return this._immediate; | ||
} | ||
|
||
static set batching(value: boolean) { | ||
if (value && this._immediate) | ||
throw new Error('Cannot batch while immediate'); | ||
this._batching = value; | ||
} | ||
static get batching() { | ||
return this._batching; | ||
} | ||
|
||
static updateAll() { | ||
ViewUpdateEmitter.instances.forEach(ref => { | ||
const instance = ref.deref(); | ||
if (instance) { | ||
instance.queueIfUpdate(); | ||
} | ||
}); | ||
} | ||
|
||
static resolveBatches() { | ||
const dedupe = new Set<ViewUpdateEmitter>(); | ||
ViewUpdateEmitter.batchedInstances.forEach(ref => { | ||
const instance = ref.deref(); | ||
if (instance) { | ||
dedupe.add(instance); | ||
} | ||
}); | ||
ViewUpdateEmitter.batchedInstances = []; | ||
for (const instance of dedupe) { | ||
instance.queueIfUpdate(); | ||
} | ||
} | ||
|
||
constructor() { | ||
ViewUpdateEmitter.instances.push(new WeakRef(this)); | ||
} | ||
|
||
callback?: Function = undefined; | ||
// this is used to trigger the update when the callback is set if there was no | ||
// callback at the time. Otherwise there can be times when the react component | ||
// has run the useEffect return to remove the callback because its remounting | ||
// or whatever, and so it won't get the update. | ||
hasUpdate = false; | ||
queued = false; | ||
|
||
on(callback: Function) { | ||
this.callback = callback; | ||
this.queueIfUpdate(); | ||
} | ||
|
||
off() { | ||
this.callback = undefined; | ||
} | ||
|
||
queueIfUpdate() { | ||
if (this.hasUpdate) { | ||
this.update(); | ||
} | ||
} | ||
|
||
queue() { | ||
if (this.queued) return; | ||
|
||
if (ViewUpdateEmitter.batching) { | ||
this.hasUpdate = true; | ||
ViewUpdateEmitter.batchedInstances.push(new WeakRef(this)); | ||
return; | ||
} | ||
|
||
if (ViewUpdateEmitter.immediate) { | ||
this.update(); | ||
} else { | ||
this.queued = true; | ||
queueMicrotask(() => this.update()); | ||
} | ||
} | ||
|
||
update() { | ||
this.queued = false; | ||
|
||
if (this.callback) { | ||
this.hasUpdate = false; | ||
this.callback(); | ||
} else { | ||
this.hasUpdate = true; | ||
} | ||
} | ||
} | ||
|
||
interface Options { | ||
debugger?: Function; | ||
} | ||
|
||
/** | ||
* Updates in the given callback are batched together and only trigger a single | ||
* render. | ||
*/ | ||
export async function batch<T>(fn: () => Promise<T>): Promise<T> { | ||
ViewUpdateEmitter.updateAll(); | ||
|
||
ViewUpdateEmitter.batching = true; | ||
const result = await fn(); | ||
ViewUpdateEmitter.reset(); | ||
return result; | ||
} | ||
|
||
/** | ||
* Updates in the given callback are executed immediately and trigger a render | ||
* immediately rather than waiting for the next microtask. This is useful for | ||
* animation tasks. | ||
* | ||
* This can have a significant performance cost so should only be used if | ||
* required. | ||
*/ | ||
export function immediate<T>(fn: () => T): T { | ||
ViewUpdateEmitter.immediate = true; | ||
const result = fn(); | ||
ViewUpdateEmitter.reset(); | ||
return result; | ||
} | ||
|
||
export function ApplicationView<T>(Comp: ReactComponent<T>, options?: Options) { | ||
let ReactiveComp: React.ComponentType<T>; | ||
|
||
if (isReactFunction(Comp)) { | ||
// use a hook based reactive wrapper when we can | ||
ReactiveComp = (props: T) => { | ||
const emitter = new ViewUpdateEmitter(); | ||
|
||
// use a dummy setState to update the component | ||
const [, setState] = useState({}); | ||
// create a memoized reactive wrapper of the original component (render) | ||
// at the very first run of the component function | ||
const render = useMemo( | ||
() => { | ||
return observe(Comp, { | ||
scheduler: () => { | ||
emitter.queue(); | ||
}, | ||
lazy: true, | ||
}); | ||
}, | ||
// Adding the original Comp here is necessary to make React Hot Reload work | ||
// it does not affect behavior otherwise | ||
[Comp] | ||
); | ||
|
||
// cleanup the reactive connections after the very last render of the component | ||
useEffect(() => { | ||
emitter.on(() => { | ||
if (options?.debugger) { | ||
options.debugger('update triggered'); | ||
} | ||
setState({}); | ||
}); | ||
|
||
return () => { | ||
emitter.off(); | ||
// We don't need to trigger a render after the component is removed. | ||
// unobserve(render); | ||
}; | ||
}, []); | ||
|
||
// run the reactive render instead of the original one | ||
return render(props); | ||
}; | ||
|
||
// if ("displayName" in Comp) { | ||
// ReactiveComp.displayName = Comp.displayName || Comp.name; | ||
// } else { | ||
// ReactiveComp.displayName = Comp.name; | ||
// } | ||
|
||
// static props are inherited by class components, | ||
// but have to be copied for function components | ||
Object.keys(Comp).forEach(key => { | ||
// @ts-ignore | ||
ReactiveComp[key] = Comp[key]; | ||
}); | ||
|
||
return memo(ReactiveComp); | ||
} else { | ||
// a HOC which overwrites render, shouldComponentUpdate and componentWillUnmount | ||
// it decides when to run the new reactive methods and when to proxy to the original methods | ||
class ReactiveClassComp extends Comp { | ||
constructor(props: T, context: any) { | ||
super(props, context); | ||
|
||
this.state = this.state || {}; | ||
// @ts-ignore | ||
this.state[COMPONENT] = this; | ||
|
||
// create a reactive render for the component | ||
this.render = observe(this.render, { | ||
scheduler: () => this.setState({}), | ||
lazy: true, | ||
}); | ||
} | ||
|
||
// react should trigger updates on prop changes, while easyState handles store changes | ||
override shouldComponentUpdate( | ||
nextProps: Readonly<T>, | ||
nextState: any, | ||
nextContext: any | ||
) { | ||
const { props, state } = this; | ||
|
||
// respect the case when the user defines a shouldComponentUpdate | ||
if (super.shouldComponentUpdate) { | ||
return super.shouldComponentUpdate(nextProps, nextState, nextContext); | ||
} | ||
|
||
// return true if it is a reactive render or state changes | ||
if (state !== nextState) { | ||
return true; | ||
} | ||
|
||
// the component should update if any of its props shallowly changed value | ||
const propKeys = Object.keys(props); | ||
const nextKeys = Object.keys(nextProps); | ||
return ( | ||
nextKeys.length !== propKeys.length || | ||
nextKeys.some(key => props[key] !== nextProps[key]) | ||
); | ||
} | ||
|
||
override componentWillUnmount() { | ||
// call user defined componentWillUnmount | ||
if (super.componentWillUnmount) { | ||
super.componentWillUnmount(); | ||
} | ||
// clean up memory used by Easy State | ||
unobserve(this.render); | ||
} | ||
} | ||
|
||
// @ts-ignore | ||
ReactiveComp = ReactiveClassComp; | ||
} | ||
|
||
ReactiveComp.displayName = Comp.displayName || Comp.name; | ||
return ReactiveComp; | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just jumping in, FYI, React 18 now batches all updates, not just updates in event handlers. Might reduce the need for manual batching if it all boils down to
setState
callsThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
batch in this context means deferring observer updates for a set of async operations