Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Polkajs provider for Substrate #108

Merged
merged 6 commits into from
Jan 3, 2024
Merged

Conversation

Rgascoin
Copy link
Member

@Rgascoin Rgascoin commented Dec 12, 2022

Feat: Providers are not handled by Substrate account
Solution: Add Polka.js support
(related to: #60)

Important Notes:

  • At this moment, the Aleph network won't be able to validate messages from provided Dot Account, until nodes upgrade their dependency substrateinterface
  • This feature is not tested, because it can only be run in the browser and it doesn't appear to have any documented tool for mocking polkadotjs extension.

Link to the PyAleph PR: aleph-im/pyaleph#358

How I verified the reliance of this feature:

  • I modify a local Aleph node with substrateinterface in 1.4.1
  • The Sign() method of Substrate have a new verification step to check the integrity of the signature using signatureVerify()
  • Make some manuals tests with toolshed

More about the polkadot version:

@BjrInt
Copy link
Member

BjrInt commented Dec 13, 2022

Waiting for the update on pyaleph before merging this.

@Rgascoin Rgascoin self-assigned this Jan 7, 2023
@BjrInt
Copy link
Member

BjrInt commented Feb 9, 2023

Merged into pyaleph, waiting for the next pyaleph release.

@MHHukiewitz MHHukiewitz merged commit 887e2cf into main Jan 3, 2024
2 of 5 checks passed
@MHHukiewitz MHHukiewitz deleted the Feat/Provider/Substrate branch January 3, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants