Chore: Allow provider polkadot signature verification #358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vider. Solution: update substrate-interface from 1.1.7 to 1.2.0
|
Could you add a unit test? |
Rgascoin
force-pushed
the
Chore/Substrate/signature
branch
2 times, most recently
from
1a2dcf7
to
e77dd11
Compare
Rgascoin
force-pushed
the
Chore/Substrate/signature
branch
from
e77dd11
to
824ff04
Compare
Here: 824ff04 I don't know if pytest can mock 2 different version of the same lib to make the test more relevant and shows a version before 1.2 can't verify the new message. |
odesenfans
approved these changes
Dec 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chore: PyAleph can not validate signature coming from Polkadotjs provider.
Solution: update substrate-interface from
1.1.7to1.2.0The minimal version to fix this issue is the
1.2.0.https://github.com/polkascan/py-substrate-interface/releases/tag/v1.2.0
This update is required for the typescript SDK: aleph-im/aleph-sdk-ts#108