Implement ASGI Lifespan protocol #294
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nt has the same timeout as a regular function invocation now (on-demand calls can have up to 3x of the compute time available now)
hoh
reviewed
Apr 20, 2023
| @@ -120,6 +122,7 @@ async def create( | |||
| await vm.start() | |||
| await vm.configure() | |||
| await vm.start_guest_api() | |||
| await self.run_code({"type": "lifespan.startup"}) | |||
There was a problem hiding this comment.
Why not launch this event from the start of the VM init1.py ?
There was a problem hiding this comment.
hoh
added a commit
that referenced
this pull request
Apr 20, 2023
ASGI specification https://asgi.readthedocs.io/en/latest/specs/lifespan.html Fixes #293 Replaces #294
2 tasks
hoh
added a commit
that referenced
this pull request
Apr 20, 2023
ASGI specification https://asgi.readthedocs.io/en/latest/specs/lifespan.html Fixes #293 Replaces #294
|
Superseded by #295 |
hoh
added a commit
that referenced
this pull request
May 10, 2023
ASGI specification https://asgi.readthedocs.io/en/latest/specs/lifespan.html Fixes #293 Replaces #294
hoh
added a commit
that referenced
this pull request
May 12, 2023
ASGI specification https://asgi.readthedocs.io/en/latest/specs/lifespan.html Fixes #293 Replaces #294
hoh
added a commit
that referenced
this pull request
May 12, 2023
ASGI specification https://asgi.readthedocs.io/en/latest/specs/lifespan.html Fixes #293 Replaces #294
hoh
added a commit
that referenced
this pull request
May 16, 2023
ASGI specification https://asgi.readthedocs.io/en/latest/specs/lifespan.html Fixes #293 Replaces #294
hoh
added a commit
that referenced
this pull request
May 17, 2023
ASGI specification https://asgi.readthedocs.io/en/latest/specs/lifespan.html Fixes #293 Replaces #294
hoh
added a commit
that referenced
this pull request
Jul 6, 2023
ASGI specification https://asgi.readthedocs.io/en/latest/specs/lifespan.html Fixes #293 Replaces #294
hoh
added a commit
that referenced
this pull request
Jul 6, 2023
ASGI specification https://asgi.readthedocs.io/en/latest/specs/lifespan.html Fixes #293 Replaces #294
hoh
added a commit
that referenced
this pull request
Jul 6, 2023
ASGI specification https://asgi.readthedocs.io/en/latest/specs/lifespan.html Fixes #293 Replaces #294
hoh
added a commit
that referenced
this pull request
Jul 6, 2023
ASGI specification https://asgi.readthedocs.io/en/latest/specs/lifespan.html Fixes #293 Replaces #294
hoh
added a commit
that referenced
this pull request
Jul 6, 2023
ASGI specification https://asgi.readthedocs.io/en/latest/specs/lifespan.html Fixes #293 Replaces #294
hoh
added a commit
that referenced
this pull request
Sep 18, 2023
ASGI specification https://asgi.readthedocs.io/en/latest/specs/lifespan.html Fixes #293 Replaces #294
hoh
added a commit
that referenced
this pull request
Sep 19, 2023
ASGI specification https://asgi.readthedocs.io/en/latest/specs/lifespan.html Fixes #293 Replaces #294
hoh
added a commit
that referenced
this pull request
Sep 25, 2023
ASGI specification https://asgi.readthedocs.io/en/latest/specs/lifespan.html Fixes #293 Replaces #294
hoh
added a commit
that referenced
this pull request
Sep 25, 2023
ASGI specification https://asgi.readthedocs.io/en/latest/specs/lifespan.html Fixes #293 Replaces #294
hoh
added a commit
that referenced
this pull request
Sep 25, 2023
ASGI specification https://asgi.readthedocs.io/en/latest/specs/lifespan.html Fixes #293 Replaces #294
hoh
added a commit
that referenced
this pull request
Sep 25, 2023
ASGI specification https://asgi.readthedocs.io/en/latest/specs/lifespan.html Fixes #293 Replaces #294
hoh
added a commit
that referenced
this pull request
Mar 12, 2024
ASGI specification https://asgi.readthedocs.io/en/latest/specs/lifespan.html Fixes #293 Replaces #294
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should solve #293 in part. Goal of this PR is to have the most basic implementation of the ASGI Lifespan protocol possible without interfering with existing VMs that do not support the lifespan call.