-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: ASGI processes did not support lifespan events #295
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but would like to test it out locally tomorrow
Needs a fix in aleph-client to work. |
416fc83
to
2ca99e2
Compare
Test by accessing Commits squashed. |
Tests fail due to the issue in aleph-client. |
@hoh Is there a reason why you did not implement the same for the Debian runtime? EDIT: Also, what's curious is that even though you did not change the Debian runtime, it also fails in the GH action (but I cannot really make out why that is, I'm still struggling with making the VM supervisor run on my machine due to Conda, duh) |
I did. The init1.py of the Debian runtime is a symbolic link to the file I modified.
The reason why the tests fail still need investigation. |
ecd5874
to
c68bce3
Compare
This needs to be rebased due to recent changes. |
3589e00
to
90aabc7
Compare
9b23de9
to
5af6534
Compare
Any idea why the tests might be failing? |
5af6534
to
8466394
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lots of unrelated code, and the demo does not work.
29881f4
to
f585266
Compare
ASGI specification https://asgi.readthedocs.io/en/latest/specs/lifespan.html Fixes #293 Replaces #294
Lifespan is a new feature that requires a new runtime to be deployed before it can be enforced.
f585266
to
8870cc9
Compare
ASGI specification https://asgi.readthedocs.io/en/latest/specs/lifespan.html
Fixes #293
Replaces #294
Missing