Fix: Network errors were hard to inspect #571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #571 +/- ##
==========================================
+ Coverage 34.61% 35.19% +0.58%
==========================================
Files 52 53 +1
Lines 4781 4844 +63
Branches 561 572 +11
==========================================
+ Hits 1655 1705 +50
- Misses 3108 3120 +12
- Partials 18 19 +1 ☔ View full report in Codecov by Sentry. |
Context: We recently added the argument `check=True` to `subprocess.run(command)` to ensure we do not ignore errors in the setup or teardown of network interfaces. Problem: Analyzing the errors that may happen during the setup or teardown of network interfaces is difficult due to the little amount of information provided by the `ip` command. It is therefore difficult to react accordingly. Solution: Switch to use `pyroute2`, a pure Python netlink library that provides the required functions with more fined grained error reports. The library `Pyroute2` is available in Debian 12 [1], however that version (0.7.2-2) is not documented anymore. It is absent from Debian 11. We therefore use the latest stable version from PyPI. [1] https://packages.debian.org/bookworm/python3-pyroute2
hoh
force-pushed
the
hoh-ip-use-pyroute2
branch
from
537a5af
to
ccbf292
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: We recently added the argument
check=Truetosubprocess.run(command)to ensure we do not ignore errors in the setup or teardown of network interfaces.Problem: Analyzing the errors that may happen during the setup or teardown of network interfaces is difficult due to the little amount of information provided by the
ipcommand. It is therefore difficult to react accordingly.Solution: Switch to use
pyroute2, a pure Python netlink library that provides the required functions with more fined grained error reports.The library
Pyroute2is available in Debian 12 [1], however that version (0.7.2-2) is not documented anymore. It is absent from Debian 11. We therefore use the latest stable version from PyPI.[1] https://packages.debian.org/bookworm/python3-pyroute2