Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Network errors were hard to inspect #571

Merged
merged 1 commit into from
Mar 13, 2024
Merged

Fix: Network errors were hard to inspect #571

merged 1 commit into from
Mar 13, 2024

Commits on Mar 12, 2024

  1. Fix: Network errors were hard to inspect 

    Context: We recently added the argument `check=True` to `subprocess.run(command)` to ensure we do not ignore errors in the setup or teardown of network interfaces.

Problem: Analyzing the errors that may happen during the setup or teardown of network interfaces is difficult due to the little amount of information provided by the `ip` command. It is therefore difficult to react accordingly.

Solution: Switch to use `pyroute2`, a pure Python netlink library that provides the required functions with more fined grained error reports.

The library `Pyroute2` is available in Debian 12 [1], however that version (0.7.2-2) is not documented anymore. It is absent from Debian 11. We therefore use the latest stable version from PyPI.

[1] https://packages.debian.org/bookworm/python3-pyroute2
    @hoh
    hoh committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    ccbf292 View commit details
    Browse the repository at this point in the history