Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Deleting a missing interface crashed #576

Merged
merged 2 commits into from
Mar 15, 2024

Fix: Deleting a missing interface crashed

3ef5692
Select commit
Loading
Failed to load commit list.
Merged

Fix: Deleting a missing interface crashed #576

Fix: Deleting a missing interface crashed
3ef5692
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Mar 14, 2024 in 1s

35.25% (+0.05%) compared to 1c0761d

View this Pull Request on Codecov

35.25% (+0.05%) compared to 1c0761d

Details

Codecov Report

Attention: Patch coverage is 66.66667% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 35.25%. Comparing base (1c0761d) to head (3ef5692).
Report is 1 commits behind head on main.

❗ Current head 3ef5692 differs from pull request most recent head 9f8f0e1. Consider uploading reports for the commit 9f8f0e1 to get more accurate results

Files Patch % Lines
src/aleph/vm/network/interfaces.py 64.28% 3 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #576      +/-   ##
==========================================
+ Coverage   35.19%   35.25%   +0.05%     
==========================================
  Files          53       53              
  Lines        4850     4862      +12     
  Branches      574      577       +3     
==========================================
+ Hits         1707     1714       +7     
- Misses       3124     3127       +3     
- Partials       19       21       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.