Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hotfix: Pay now is broken if In-Page is disabled #240

Merged
merged 2 commits into from
Nov 3, 2023
Merged

hotfix: Pay now is broken if In-Page is disabled #240

merged 2 commits into from
Nov 3, 2023

Conversation

Benjamin-Freoua-Alma
Copy link
Member

Reason for change

Linear task

Code changes

We don't display form for in page in Pay now Payment

How to test

Disable In-page and make a payment Pay now

Checklist for authors and reviewers

  • The title of the PR uses business wording, not technical jargon, for the changelog readers to understand it
  • The PR implements the changes asked in the referenced task / issue
  • The automated tests are compliant with the testing strategy
  • The tests are relevant, and cover the corner/error cases, not only the happy path
  • You understand the impact of this PR on existing code/features
  • The changes include adequate logging and Datadog traces
  • Documentation is updated (API, developer documentation, ADR, Notion...)

Non applicable

@Benjamin-Freoua-Alma Benjamin-Freoua-Alma self-assigned this Nov 3, 2023
@Benjamin-Freoua-Alma
Copy link
Member Author

Capture d’écran 2023-11-03 à 15 33 21

@Benjamin-Freoua-Alma Benjamin-Freoua-Alma changed the title fix: payment paynow if inpage is disabled hotfix: payment paynow if inpage is disabled Nov 3, 2023
@Benjamin-Freoua-Alma Benjamin-Freoua-Alma changed the title hotfix: payment paynow if inpage is disabled hotfix: Pay now is broken if In-Page is disabled Nov 3, 2023
@Benjamin-Freoua-Alma Benjamin-Freoua-Alma merged commit 3de4038 into main Nov 3, 2023
1 of 2 checks passed
@Benjamin-Freoua-Alma Benjamin-Freoua-Alma deleted the hotfix/paynow-if-inpage-disabled branch November 3, 2023 14:42
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ClaireAlma ClaireAlma ClaireAlma approved these changes

@Francois-Gomis Francois-Gomis Awaiting requested review from Francois-Gomis

@CamilleFljt CamilleFljt Awaiting requested review from CamilleFljt

Assignees

@Benjamin-Freoua-Alma Benjamin-Freoua-Alma

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Benjamin-Freoua-Alma @ClaireAlma