Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hotfix: Pay now is broken if In-Page is disabled #240

Merged
merged 2 commits into from
Nov 3, 2023
Merged

hotfix: Pay now is broken if In-Page is disabled #240

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
53e6c82
fix: payment paynow if inpage is disabled
Benjamin-Freoua-Alma Nov 3, 2023
5f609f4
update changelog
Benjamin-Freoua-Alma Nov 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# Changelog

## v3.1.1

- fix: Pay now if In-Page is disabled

## v3.1.0

- feat: In-Page: Now we use the setForm in payment option and refactored to vanilla Javascript (we don't use Jquery anymore)
Expand Down
4 changes: 2 additions & 2 deletions alma/alma.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@

class Alma extends PaymentModule
{
const VERSION = '3.1.0';
const VERSION = '3.1.1';

public $_path;
public $local_path;
Expand Down Expand Up @@ -65,7 +65,7 @@ public function __construct()
{
$this->name = 'alma';
$this->tab = 'payments_gateways';
$this->version = '3.1.0';
$this->version = '3.1.1';
$this->author = 'Alma';
$this->need_instance = false;
$this->bootstrap = true;
Expand Down
1 change: 0 additions & 1 deletion alma/controllers/hook/PaymentOptionsHookController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,6 @@ public function run($params)
if ($isPayNow) {
$textPaymentButton = SettingsCustomFieldsHelper::getPayNowButtonTitleByLang($idLang);
$descPaymentButton = SettingsCustomFieldsHelper::getPayNowButtonDescriptionByLang($idLang);
$isInPageEnabled = true;
}

$action = $this->context->link->getModuleLink(
Expand Down
4 changes: 3 additions & 1 deletion alma/views/templates/hook/_partials/feePlan.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,9 @@
{capture assign='total'}{l s='Total' mod='alma'}{/capture}
{capture assign='firstAmount'}{almaFormatPrice cents=$plans[0].total_amount}{/capture}
{capture assign='fees'}{almaFormatPrice cents=$plans[0].customer_fee}{/capture}
{capture assign='nextAmounts'}{almaFormatPrice cents=$plans[1].total_amount}{/capture}
{if $installmentsCount > 1}
{capture assign='nextAmounts'}{almaFormatPrice cents=$plans[1].total_amount}{/capture}
{/if}

{if $oneLiner}
<span class="alma-fee-plan--description">
Expand Down