FEAT: Improve antenna array processing and plotting #4626
Conversation
- Add default matplotlib settings to plot.py - Add decorator update_plot_settings to plot.py - Update some docstrings - Correct some errors of return type for plotting methods.
Bring all plotting and rendering into the method plot_farfield_contour so that it can be customized to far-field data.
|
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4626 +/- ##
==========================================
- Coverage 80.82% 80.76% -0.07%
==========================================
Files 120 120
Lines 54600 54679 +79
==========================================
+ Hits 44132 44161 +29
- Misses 10468 10518 +50 |
Iron Python does not allow a comma after the **kwargs in plot_farfield_contour
Iron Python does not allow a comma after the **kwargs in plot_farfield_contour
There was a problem hiding this comment.
LGTM
@dcrawforAtAnsys Thanks for this improvement!
@Samuelopez-ansys Thanks for helping with debugging. What was the issue ?
|
@SMoraisAnsys After debugging, I found that with the new decorator, the plot is opened in the unit test, but until the user do not close it, the script/test is alive forever. We need to have two options, check a matplotlib option to allow going ahead with the script when show=True, or like I did, do not test the show=True case. We can discuss it later. @dcrawforAtAnsys |
Add suggestions from @PipKat Co-authored-by: Kathy Pippert <[email protected]>
|
@dcrawforAtAnsys If @PipKat suggestions were added, please resolve the conversation. |
Co-authored-by: Kathy Pippert <[email protected]>
|
@dcrawforAtAnsys Can we merge? |
Following #4626 and #4708, theses changes aim at making our code base consistent. The changes consist in returning Matplotlib figure objects on methods that were returning a list of value. In the case of polar_plot_3d_pyvista, a Pyvista plotter object is returned when, before, a boolean was returned if one wanted to show the figure or save it in a file.
Minor improvements to plotting and functionality to support array phase excitations for beam-steering in HFSS.