REFACTOR: Extend consistency on plot methods #4723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Following #4626 and #4708, theses changes aim at making our code base consistent. The changes consist in returning Matplotlib figure objects on methods that were returning a list of value. In the case of polar_plot_3d_pyvista, a Pyvista plotter object is returned when, before, a boolean was returned if one wanted to show the figure or save it in a file.
|
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
Devin-Crawford
previously approved these changes
May 24, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4723 +/- ##
=======================================
Coverage 80.42% 80.42%
=======================================
Files 121 121
Lines 55116 55071 -45
=======================================
- Hits 44328 44293 -35
+ Misses 10788 10778 -10 |
|
All good. |
|
Inadvertently closed. LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #4626 and #4708, theses changes aim at making our code base consistent.
The changes consist in returning
matplotlibfigure objects on methods that were returning a list of value.In the case of
polar_plot_3d_pyvista, apyvistaplotter object is returned when, before, a boolean was returned if one wanted to show the figure or save it in a file.This changes should be performed before merging #4702