Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

REFACTOR: Extend consistency on plot methods #4723

Merged
merged 8 commits into from
May 27, 2024
Merged

REFACTOR: Extend consistency on plot methods #4723

merged 8 commits into from
May 27, 2024

Commits on May 24, 2024

  1. REFACTOR: Clean up plot.py file

    @SMoraisAnsys
    SMoraisAnsys committed May 24, 2024
    Configuration menu
    Copy the full SHA
    b388c51 View commit details
    Browse the repository at this point in the history

  2. REFACTOR: make plot methods consistent 

    Following #4626 and #4708, theses changes aim at making our
code base consistent. The changes consist in returning Matplotlib
figure objects on methods that were returning a list of value.
In the case of polar_plot_3d_pyvista, a Pyvista plotter object
is returned when, before, a boolean was returned if one wanted to
show the figure or save it in a file.
    @SMoraisAnsys
    SMoraisAnsys committed May 24, 2024
    Configuration menu
    Copy the full SHA
    7f7c9e3 View commit details
    Browse the repository at this point in the history

  3. FIX: Add missing show argument in plot_2d_chart

    @SMoraisAnsys
    SMoraisAnsys committed May 24, 2024
    Configuration menu
    Copy the full SHA
    1cdd02e View commit details
    Browse the repository at this point in the history

  4. FIX: Add missing show argument in plot methods

    @SMoraisAnsys
    SMoraisAnsys committed May 24, 2024
    Configuration menu
    Copy the full SHA
    f84ed77 View commit details
    Browse the repository at this point in the history

  5. FIX: Add missing show argument

    @SMoraisAnsys
    SMoraisAnsys committed May 24, 2024
    Configuration menu
    Copy the full SHA
    627199e View commit details
    Browse the repository at this point in the history

  6. FIX: Handle show_legend as argument

    @SMoraisAnsys
    SMoraisAnsys committed May 24, 2024
    Configuration menu
    Copy the full SHA
    354704f View commit details
    Browse the repository at this point in the history

  7. TESTS: Rework test check with Figure and Plotter

    @SMoraisAnsys
    SMoraisAnsys committed May 24, 2024
    Configuration menu
    Copy the full SHA
    126b11b View commit details
    Browse the repository at this point in the history

Commits on May 27, 2024

  1. Merge branch 'main' into refactor/extend-consistency-on-plot-methods

    @Devin-Crawford
    Devin-Crawford authored May 27, 2024
    Configuration menu
    Copy the full SHA
    9d61952 View commit details
    Browse the repository at this point in the history