FEAT: Circuit current probe

[boyang2022]

No description provided.

[ansys-reviewer-bot]

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.40%. Comparing base (33278b9) to head (77af806).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5352      +/-   ##
==========================================
+ Coverage   84.38%   84.40%   +0.01%     
==========================================
  Files         140      140              
  Lines       58635    58645      +10     
==========================================
+ Hits        49479    49499      +20     
+ Misses       9156     9146      -10     

[Samuelopez-ansys]

Hi @boyang2022 , you missed to test when you do not define the location. Thank you for the pull request!

[SMoraisAnsys]

Hey @boyang2022 , thanks for the contribution !

This changes seem to be copy pasted from create_voltage_probe (which isn't a problem!). Could you refactor that to have a single method with an additional argument to distinguish between voltage and current and which would contain the logic, e.g. __create_probe ?

That way, both create_voltage_probe and create_current_probe could call that method behind the scene and that would help us to maintain both at the same time.

[Samuelopez-ansys]

LGTM

[SMoraisAnsys]

Could you please revert the parameter name as an optional input ? This would introduce a breaking change for users and from the changes you are doing, I don't think it is required.
@Samuelopez-ansys If you think that changing name as a required value is a good thing, feel free to discard my review.

[SMoraisAnsys]

LGTM