Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: close UI by click X should not trigger parametrization #5367

Merged
merged 4 commits into from
Nov 11, 2024

Conversation

hui-zhou-a
Copy link
Contributor

  • Release desktop as soon as necessary information is extracted from active design
  • The old implementation creates a new parametrized design even the user click X to close the window

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added the bug Something isn't working label Nov 1, 2024
Copy link

codecov bot commented Nov 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.38%. Comparing base (dafbb23) to head (12d25f4).
Report is 18 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5367      +/-   ##
==========================================
+ Coverage   84.34%   84.38%   +0.04%     
==========================================
  Files         140      140              
  Lines       58460    58503      +43     
==========================================
+ Hits        49308    49368      +60     
+ Misses       9152     9135      -17     

Copy link
Collaborator

@SMoraisAnsys SMoraisAnsys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Samuelopez-ansys Samuelopez-ansys merged commit ea93f1b into main Nov 11, 2024
42 checks passed
@Samuelopez-ansys Samuelopez-ansys deleted the fix-parametrize-edb branch November 11, 2024 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants