Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: close UI by click X should not trigger parametrization #5367

Merged
merged 4 commits into from
Nov 11, 2024
Merged

FIX: close UI by click X should not trigger parametrization #5367

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
41a2f0a
FIX: close UI by click X should not trigger parametrization
samomania21 Oct 31, 2024
5f5c37c
FIX: set default not to parametrized anything
samomania21 Nov 1, 2024
f139a7c
minor fix
samomania21 Nov 6, 2024
12d25f4
minor fix
samomania21 Nov 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
93 changes: 56 additions & 37 deletions src/ansys/aedt/core/workflows/hfss3dlayout/parametrize_edb.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,14 @@


def frontend(): # pragma: no cover
default_values = {
"layer": 0,
"material": 0,
"padstacks": 0,
"nets": 0,
"relative": 0,
}

app = ansys.aedt.core.Desktop(
new_desktop=False,
version=version,
Expand All @@ -65,9 +73,13 @@ def frontend(): # pragma: no cover
student_version=is_student,
)
active_project = app.active_project()
active_design = app.active_design()
aedb_path = os.path.join(active_project.GetPath(), active_project.GetName() + ".aedb")
edb = Edb(aedb_path, active_design.GetName().split(";")[1], edbversion=version)
active_project_path = active_project.GetPath()
active_project_name = active_project.GetName()
aedb_path = os.path.join(active_project_path, active_project_name + ".aedb")
active_design_name = app.active_design().GetName().split(";")[1]

app.release_desktop(False, False)
edb = Edb(aedb_path, active_design_name, edbversion=version)

import tkinter
from tkinter import ttk
Expand Down Expand Up @@ -98,7 +110,7 @@ def frontend(): # pragma: no cover
var9.set("New project name: ")
label9.grid(row=0, column=0, pady=10)
project_name = tkinter.Entry(master, width=30)
project_name.insert(tkinter.END, generate_unique_name(active_project.GetName(), n=2))
project_name.insert(tkinter.END, generate_unique_name(active_project_name, n=2))
project_name.grid(row=0, column=1, pady=10, padx=5)

var10 = tkinter.StringVar()
Expand All @@ -108,7 +120,7 @@ def frontend(): # pragma: no cover
relative = tkinter.IntVar()
check5 = tkinter.Checkbutton(master, width=30, variable=relative)
check5.grid(row=0, column=3, pady=10, padx=5)
relative.set(1)
relative.set(default_values["relative"])

var1 = tkinter.StringVar()
label1 = tkinter.Label(master, textvariable=var1)
Expand All @@ -117,7 +129,7 @@ def frontend(): # pragma: no cover
layers = tkinter.IntVar()
check1 = tkinter.Checkbutton(master, width=30, variable=layers)
check1.grid(row=1, column=1, pady=10, padx=5)
layers.set(1)
layers.set(default_values["layer"])

var2 = tkinter.StringVar()
label2 = tkinter.Label(master, textvariable=var2)
Expand All @@ -126,7 +138,7 @@ def frontend(): # pragma: no cover
materials = tkinter.IntVar()
check2 = tkinter.Checkbutton(master, width=30, variable=materials)
check2.grid(row=1, column=3, pady=10, padx=5)
materials.set(1)
materials.set(default_values["material"])

var3 = tkinter.StringVar()
label3 = tkinter.Label(master, textvariable=var3)
Expand All @@ -135,7 +147,7 @@ def frontend(): # pragma: no cover
padstacks = tkinter.IntVar()
check3 = tkinter.Checkbutton(master, width=30, variable=padstacks)
check3.grid(row=2, column=1, pady=10, padx=5)
padstacks.set(1)
padstacks.set(default_values["padstacks"])

var5 = tkinter.StringVar()
label5 = tkinter.Label(master, textvariable=var5)
Expand All @@ -160,7 +172,7 @@ def frontend(): # pragma: no cover
nets = tkinter.IntVar()
check4 = tkinter.Checkbutton(master, width=30, variable=nets)
check4.grid(row=4, column=1, pady=10, padx=5)
nets.set(1)
nets.set(default_values["nets"])

var8 = tkinter.StringVar()
label8 = tkinter.Label(master, textvariable=var8)
Expand All @@ -174,7 +186,10 @@ def frontend(): # pragma: no cover
net_list.insert(idx, net)
idx += 1

master.flag = False

def callback():
master.flag = True
master.layers_ui = layers.get()
master.materials_ui = materials.get()
master.padstacks_ui = padstacks.get()
Expand All @@ -191,34 +206,37 @@ def callback():
b = tkinter.Button(master, text="Create Parametric Model", width=40, command=callback)
b.grid(row=5, column=1, pady=10)

edb.close_edb()
tkinter.mainloop()

layers_ui = getattr(master, "layers_ui", extension_arguments["parametrize_layers"])
materials_ui = getattr(master, "materials_ui", extension_arguments["parametrize_materials"])
padstacks_ui = getattr(master, "padstacks_ui", extension_arguments["parametrize_padstacks"])
nets_ui = getattr(master, "nets_ui", extension_arguments["parametrize_traces"])
nets_filter_ui = getattr(master, "nets_filter", extension_arguments["nets_filter"])
poly_ui = getattr(master, "poly_ui", extension_arguments["expansion_polygon_mm"])
voids_ui = getattr(master, "voids_ui", extension_arguments["expansion_void_mm"])
project_name_ui = getattr(master, "project_name_ui", extension_arguments["project_name"])
relative_ui = getattr(master, "relative_ui", extension_arguments["relative_parametric"])

output_dict = {
"aedb_path": os.path.join(active_project.GetPath(), active_project.GetName() + ".aedb"),
"design_name": active_design.GetName().split(";")[1],
"parametrize_layers": layers_ui,
"parametrize_materials": materials_ui,
"parametrize_padstacks": padstacks_ui,
"parametrize_traces": nets_ui,
"nets_filter": nets_filter_ui,
"expansion_polygon_mm": float(poly_ui),
"expansion_void_mm": float(voids_ui),
"relative_parametric": relative_ui,
"project_name": project_name_ui,
}
edb.close_edb()
app.release_desktop(False, False)
return output_dict
if master.flag:
layers_ui = getattr(master, "layers_ui", extension_arguments["parametrize_layers"])
materials_ui = getattr(master, "materials_ui", extension_arguments["parametrize_materials"])
padstacks_ui = getattr(master, "padstacks_ui", extension_arguments["parametrize_padstacks"])
nets_ui = getattr(master, "nets_ui", extension_arguments["parametrize_traces"])
nets_filter_ui = getattr(master, "net_list_ui", extension_arguments["nets_filter"])
poly_ui = getattr(master, "poly_ui", extension_arguments["expansion_polygon_mm"])
voids_ui = getattr(master, "voids_ui", extension_arguments["expansion_void_mm"])
project_name_ui = getattr(master, "project_name_ui", extension_arguments["project_name"])
relative_ui = getattr(master, "relative_ui", extension_arguments["relative_parametric"])

output_dict = {
"aedb_path": os.path.join(active_project_path, active_project_name + ".aedb"),
"design_name": active_design_name,
"parametrize_layers": layers_ui,
"parametrize_materials": materials_ui,
"parametrize_padstacks": padstacks_ui,
"parametrize_traces": nets_ui,
"nets_filter": nets_filter_ui,
"expansion_polygon_mm": float(poly_ui),
"expansion_void_mm": float(voids_ui),
"relative_parametric": relative_ui,
"project_name": project_name_ui,
}

return output_dict
else:
return False


def main(extension_arguments):
Expand Down Expand Up @@ -295,5 +313,6 @@ def main(extension_arguments):
for output_name, output_value in output.items():
if output_name in extension_arguments:
args[output_name] = output_value

main(args)
main(args)
else:
main(args)
Loading