🐛 FIX: trigger password score on init (#717)

* 🐛 FIX: trigger password score on init * 🚀 RELEASE: bump version
antoantonyk · Nov 5, 2023 · 9234511 · 9234511
1 parent 25adc10
commit 9234511
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 16 deletions.
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "password-strength-meter",
-  "version": "9.0.0",
+  "version": "9.0.1",
   "scripts": {
     "ng": "ng",
     "serve": "ng serve",

diff --git a/projects/password-strength-meter/package.json b/projects/password-strength-meter/package.json
@@ -1,6 +1,6 @@
 {
   "name": "angular-password-strength-meter",
-  "version": "9.0.0",
+  "version": "9.0.1",
   "dependencies": {
     "tslib": "^2.5.0"
   },

diff --git a/projects/password-strength-meter/src/lib/password-strength-meter.component.ts b/projects/password-strength-meter/src/lib/password-strength-meter.component.ts
@@ -7,8 +7,6 @@ import {
   EventEmitter,
   HostBinding,
   OnInit,
-  inject,
-  DestroyRef,
 } from '@angular/core';
 import { takeUntilDestroyed } from '@angular/core/rxjs-interop';
 import {
@@ -30,9 +28,7 @@ import {
   templateUrl: './password-strength-meter.component.html',
   styleUrls: ['./password-strength-meter.component.scss'],
 })
-export class PasswordStrengthMeterComponent implements OnInit, OnChanges {
-  private destroyRef = inject(DestroyRef);
-
+export class PasswordStrengthMeterComponent implements OnChanges {
   @Input() password: string;
 
   @Input() minPasswordLength = 8;
@@ -58,9 +54,17 @@ export class PasswordStrengthMeterComponent implements OnInit, OnChanges {
 
   constructor(
     private passwordStrengthMeterService: IPasswordStrengthMeterService
-  ) {}
+  ) {
+    this.init();
+  }
+
+  ngOnChanges(changes: SimpleChanges) {
+    if (changes.password) {
+      this.passwordChangeObservable$.next(this.password);
+    }
+  }
 
-  ngOnInit(): void {
+  private init(): void {
     this.passwordChangeObservable$
       .pipe(
         distinctUntilChanged(),
@@ -81,7 +85,7 @@ export class PasswordStrengthMeterComponent implements OnInit, OnChanges {
           const result = this.calculateScore(value);
           return of(result);
         }),
-        takeUntilDestroyed(this.destroyRef)
+        takeUntilDestroyed()
       )
       .subscribe((result: FeedbackResult) => {
         this.passwordStrength = result.score;
@@ -95,12 +99,6 @@ export class PasswordStrengthMeterComponent implements OnInit, OnChanges {
       });
   }
 
-  ngOnChanges(changes: SimpleChanges) {
-    if (changes.password) {
-      this.passwordChangeObservable$.next(this.password);
-    }
-  }
-
   private calculateScore(value: string): FeedbackResult {
     if (this.enableFeedback) {
       return this.passwordStrengthMeterService.scoreWithFeedback(value);