Make feedback API reactive compatible #604
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ladyginan Thanks a lot for the suggestion. Since I updated the project to split the dependencies, I have created a separate PR here - #715 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, dear author of the library,
I tried to implement a custom password strength meter service for a project I'm working on and faced the issue that the library's API works only in a non-reactive way. In my project, I have a reactive API that checks whether a password is strong enough, and I want to be able to customize visual password strength representation according to a reactive API response.
The PR allows the library to process responses asynchronously and synchronously from the
scoreWithFeedbackfunction. The PR doesn't currently have changes to thescorefunction, but I can do that if desired.One test is broken due to asynchronous changes; I commented on it and put TODO.
It would be greatly appreciated if these changes could be accepted🙏