Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable remote gradle cache and build scan for GitHub Actions workflows #28539

Merged
merged 2 commits into from
Sep 20, 2023

Conversation

andreydevyatkin
Copy link
Collaborator

@andreydevyatkin andreydevyatkin commented Sep 19, 2023

fixes #28378

The following changes have been made:

  • Updated the setup-environment-action/action.yml action to publish build scan for all GitHub Actions workflows by adding the mandatory step gradle/gradle-build-action@v2
  • Added missing Gradle configs for each workflow

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

publish gradle build scans

publish gradle build scans
@github-actions
Copy link
Contributor

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

@andreydevyatkin
Copy link
Collaborator Author

Run RAT PreCommit

@github-actions
Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @damccorm for label build.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

publish gradle build scans
@andreydevyatkin
Copy link
Collaborator Author

Run RAT PreCommit

Copy link
Contributor

@damccorm damccorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@damccorm damccorm merged commit 93c3224 into apache:master Sep 20, 2023
4 of 5 checks passed
@tvalentyn
Copy link
Contributor

seeing many errors in post step of /.github/actions/setup-action : Index out of range .

sample run: https://github.com/apache/beam/actions/runs/6250219560/job/16969848231?pr=28557

actions/runner#2816 looks similar . Is it caused by this change?

@tvalentyn
Copy link
Contributor

tvalentyn commented Sep 20, 2023

from reading actions/runner#2816 , it might be caused when a cached version of a step has a different # of stages. recommendation is to use the same version for a checkout step. I am seeing we using checkout@v3 in several suites, but v4 in all other suites - could this be an issue?

:workflows$ rg "actions/checkout" .    | grep v3
./beam_PostCommit_Java_Nexmark_Spark.yml:      - uses: actions/checkout@v3
./beam_PostCommit_Java_Nexmark_Dataflow.yml:      - uses: actions/checkout@v3
./README.md:      - uses: actions/checkout@v3
./README.md:      - uses: actions/checkout@v3
./beam_PostCommit_Java_Nexmark_Flink.yml:      - uses: actions/checkout@v3
./beam_PostCommit_Java_Nexmark_Direct.yml:      - uses: actions/checkout@v3
./beam_PostCommit_Java_Nexmark_Dataflow_V2_Java.yml:      - uses: actions/checkout@v3
./beam_PostCommit_Python_Nexmark_Direct.yml:      - uses: actions/checkout@v3
./beam_PostCommit_Javadoc.yml:      - uses: actions/checkout@v3
./beam_PostCommit_Java_Nexmark_Dataflow_V2.yml:      - uses: actions/checkout@v3

@volatilemolotov
Copy link
Contributor

@tvalentyn I just checked and i see failures in workflows with v3 and v4 so i dont think that could be the cause.
The index issue happens in setup repository post step which does not use checkout action but instead uses bash and git command.

The issue im looking at is that checkout pulls in the current master. Then the setup action pulls in the merge comment and that causes a difference in number of steps. I have checked the PR and no changes to actions were made so im not sure from where the issue comes from

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: enable remote gradle cache and build scan for newly added github action workflow
4 participants