-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Temporarily fix pip check failure on xgboost and grpcio #32432
Conversation
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
Run Python_ML PreCommit 3.8 |
R: @tvalentyn @Abacn |
Assigning reviewers. If you would like to opt out of this review, comment R: @damccorm for label python. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
Note that the PR triggered workflow won't run on the change in |
Are you sure? I think the tests are run with my changes in .github/, since I see the new tox environment I created for macos is used in the tests. For example: |
ah you are right, I remembered there is this kind of limitation but looks like it does not applies to this specific test. Turns out the limitation applies to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm for python_test. For dependency change defer to ml owner
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks - lets just try to revert the mac pieces once grpc is ready
Thanks! I have created the task for reverting the mac change #32431. |
Originally, this PR is to pin pip to version 24.1, so that
pip check
would not fail on xgboost-1.7.6 and grpcio-1.66.1.After some attempts, it seems it is a bit inconvenient to enforce pip version, especially inside the venv set up by tox.
Therefore, we decide to make the following changes
for xgboost, since we don't have any plan to invest further on it, we are going to remove it from deps. After that, the xgboost related tests in the ML test suite will be skipped. We can put it back in the future if we decide to support xgboost again ([Feature request]: Support XGBoost 2.x #31252) .
for grpcio, the failure only occurs on MacOS, so we decide to skip
pip check
on MacOS until pip check failed on grpcio in macos-arm64 grpc/grpc#37660 is fixed.#fixes #31285