-
Notifications
You must be signed in to change notification settings - Fork 971
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Support discovery monitoring instance through http_sd #1791
Conversation
I haven't add sd for any collectors, it needs to be discussed which collector should be supported for sd |
👍👍 This design implementation is eye-catching and is a good idea. I don't seem to find the part that automatically discovers and creates multiple instances through the information returned by the http_sd interface. For example, http_sd returns ip1-port1 ip2-port2 ip3-port3. We create three new monitoring instances based on these three automatic discoveries. |
@tomsun28 What I coded in this pr is update host and port automatically. |
@tomsun28 |
👍👍 okay okay. It is not urgent, depends on your time. Recommend to release an first apache version first and after then consider integrate this big feature. |
OK, I will close this pr. And I will open another pr after first apache version released and I finished this new feature. |
What's changed?
Corresponding issue:
#1625
Service discovery can be available for all collectors now and I provide http_sd as a deafult strategy.
There's something different between one time task and cyclic task while fetching instance info:
How to add service discovery for collector?
CommonProtocol
interfacegetSupportProtocolClass
and point out which protocol is used for current collectorTest result
What's more
the priority of sd is higher than host, which means it will use sd first if you config host and http_sd simultaneously.
Checklist
Add or update API