Fixes HotSpot JDK 22 CI failure due to GR-54293 #32267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linghengqian
force-pushed
the
fix-espresso
branch
from
6c50103
to
c2813e3
Compare
taojintianxia
approved these changes
Jul 25, 2024
linghengqian
commented
Jul 25, 2024
There was a problem hiding this comment.
- Note that https://mvnrepository.com/artifact/org.graalvm.espresso/espresso-runtime-resources-linux-amd64/24.0.2 has changed LICENSE.
org.graalvm.espresso:espresso-runtime-resources-linux-amd64:24.0.1isGNU General Public License, version 2, butorg.graalvm.espresso:espresso-runtime-resources-linux-amd64:24.0.2isGraalVM Free Terms and Conditions (GFTC) including License for Early Adopter Versions. Perhaps a follow-up issue tracking is needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/apache/shardingsphere/actions/runs/10081728571/job/27887106603 .
Changes proposed in this pull request:
RuntimeResourceIdrelated Maven dependencies in the classpath, because Espresso'sRuntimeResourceIdis allowed to have multiple configurations. Currently, there is only one known implementation of RuntimeResourceId, which isorg.graalvm.espresso:espresso-runtime-resources-linux-amd64:24.0.2. But I still think this is not reasonable, after all, I also need this Maven dependency on GraalVM CE For JDK 22.0.2.sdk use java 21.0.2-opento verify that the execution of unit tests under HotSpot JDK has returned to normal.Before committing this PR, I'm sure that I have checked the following options:
./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.