feat: Added custom label and annotations to the pods of the server, repo, application set controller, and application controller

[enriqueav99]

What type of PR is this?

/kind enhancement

What does this PR do / why we need it:

Add the feature to add custom labels and annotations to the pods of the server, repo, application set controller, and application controller.

Have you updated the necessary documentation?

• Documentation update is required by this PR.
• Documentation has been updated.

Which issue(s) this PR fixes:

Fixes #1530 #637

How to test changes / Special notes to the reviewer:
Apply the following yaml

apiVersion: argoproj.io/v1beta1
kind: ArgoCD
metadata:
  name: argocd-sample
spec:
  server:
    customPodLabels:
      custom: label
      custom2: server
    customPodAnnotations:
      custom: annotation
      custom2: server
  repo:
    customPodLabels:
      custom: label
      custom2: repo
    customPodAnnotations:
      custom: annotation
      custom2: repo
  controller:
    customPodLabels:
      custom: label
      custom2: controller
    customPodAnnotations:
      custom: annotation
      custom2: controller
  applicationSet:
    customPodLabels:
      custom: label
      custom2: applicationSet
    customPodAnnotations:
      custom: annotation
      custom2: applicationSet

[enriqueav99]

I deleted the test I made because I found it unnecessary and it wasn't working well in the CI. However, it passes when I run it locally (A classic)

[enriqueav99]

I don't understand why the kuttl/harness/1-036_validate_role_rolebinding_for_source_namespace test sometimes passes and sometimes doesn't, even though I haven't changed any code. For example, in the last commit, I deleted a test I created, and it didn't pass, but in the previous two commits, it did pass.

[svghadi]

Hi @enriqueav99,

kuttl/harness/1-036_validate_role_rolebinding_for_source_namespace

is a known flaky test. You can ignore it.

[enriqueav99]

Hi @enriqueav99,

kuttl/harness/1-036_validate_role_rolebinding_for_source_namespace

is a known flaky test. You can ignore it.

Thaks for your reply! If it is a knwon "issue" I think taht the PR is ready to be reviewed

[enriqueav99]

Hi! Could someone please review this? I think it's something simple and it would be really helpful for me at work 😄

[svghadi]

Hi @enriqueav99, thanks for the PR. I will try to get to it in next few days.

[svghadi]

Hi @enriqueav99 , can we the naming convention from

• customPodLabels to labels
• customPodAnnotations to annotations

[enriqueav99]

Hi @enriqueav99 , can we the naming convention from

• customPodLabels to labels
• customPodAnnotations to annotations

Hi! I changed the name of them! Thanks for yor time, any other feedback or review Will be well recived :D

[svghadi]

Thanks @enriqueav99.
Ran some tests, overall looks good. Left some suggestions.

[enriqueav99]

Thanks for the review @svghadi! Please, if another change is needed, let me know 😄

[svghadi]

LGTM. Thanks @enriqueav99 for the contribution! Once you resolve the conflict, the PR will be good to go.

[enriqueav99]

All conflicts are solved, thanks @svghadi for your help!

[svghadi]

Awesome 🎉 . Thanks a lot @enriqueav99 !!

[enriqueav99]

Thanks @svghadi very much 😄 . Do you know if an early release is planned? I need this urgently for my organization, and we want to create a schedule to make the necessary changes to include this new feature and start monitoring our ArgoCD clusters 🚀

[svghadi]

We do one release per quarter. The next planned release is somewhere at start of December. I am afraid that an early release won't be possible. Currently we do manual releases, there is no automation in place 😞.

[enriqueav99]

Then we have to wait 😄. Would an automation to trigger a release fit, or are you not interested? I could try to do something

[svghadi]

It's on my todo for a while now. Need to plan it.

I could try to do something

Sure. I will come up with a plan and we can collaborate if you are interested.

[enriqueav99]

It's on my todo for a while now. Need to plan it.

I could try to do something

Sure. I will come up with a plan and we can collaborate if you are interested.

For sure! I'd be happy to help. Is there any communication channel where we can talk?

[svghadi]

You can reach out to me on CNCF slack, either in #argo-cd-contributors channel or direct message.