Allow automatic port selection by tomcat

[pschwarzer-tt]

Short description of what this resolves:

As discussed in here: #115 here the pull request to allow automatic port selection by the arquillian tomcat plugin.

I added comments to all done changes.

Changes proposed in this pull request:

• allow automatic port selection by Tomcat class

Fixes: #

• changed final HTTPContext httpContext = new HTTPContext(configuration.getBindAddress(), configuration.getBindHttpPort()); to new HTTPContext(tomcat.getHost().getName(), tomcat.getConnector().getLocalPort()); in Tomcat8EmbeddedContainer.java so HTTPContext uses port choosen by Tomcat, and no longer set by user in configuration. This allows setting of 0 and to let tomcat choose an available port by its own.

• changed ((StandardHost) host).setUnpackWARs(configuration.isUnpackArchive()); back to embeddedHostConfig.setUnpackWARs(configuration.isUnpackArchive()); because in out arquillian setup, ((StandardHost) host).setUnpackWARs(configuration.isUnpackArchive()); will not work propably

[rhusar]

Hi @pschwarzer-tt, any chance you are still active and could rebase the change?

[jansohn]

Hi @pschwarzer-tt, any chance you are still active and could rebase the change?

After looking at his profile I doubt he is still active. Can you rebase it yourself or should I open a new PR? I'm also interested in this feature / fix.

[rhusar]

Hi @pschwarzer-tt, any chance you are still active and could rebase the change?

After looking at his profile I doubt he is still active. Can you rebase it yourself or should I open a new PR? I'm also interested in this feature / fix.

@jansohn I am afraid so :-(

This needs more work and testing than just simple rebase, I can have a look next week at the earliest. You can take a stab if you want.

[pschwarzer-tt]

Hi, its to long ago, not working with this anymore. Can someone else take over?

[rhusar]

Hi, its to long ago, not working with this anymore. Can someone else take over?

Thanks @pschwarzer-tt ! @jansohn has - #179

Closing!