fix: fixed random port selection support #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I built and tested this locally and it fixed the problem when using bindHttpPort=0. Maybe we should adapt the tests to use that random port, too? |
|
Approved CI just now. |
rhusar
approved these changes
Oct 2, 2024
|
LGTM, thanks @jansohn! |
Yes - I will change that. |
#181 should suffice. I don't think adding a new configuration to test static port is necessary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description of what this resolves:
Fixes the scenario with random / automatic port selection when starting the embedded Tomcat instance. Supersedes #116
Changes proposed in this pull request:
bindHttpPort=0in configurationFixes: #115