Update upload and failed buckets configuration #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jraddaoui
changed the title
scollazo
requested changes
Oct 2, 2024
| key = "{{ pipeline.watched_key }}" | ||
| secret = "{{ pipeline.watched_secret }}" | ||
| accessKey = "{{ pipeline.watched_key }}" | ||
| secretKey = "{{ pipeline.watched_secret }}" | ||
| region = "{{ pipeline.watched_region }}" | ||
| bucket = "failed-pips" |
There was a problem hiding this comment.
failed-pips and failed-sips should be added to the data dictionary, as we do with the sips one
There was a problem hiding this comment.
Not really related with these changes and I don't want to introduce two new variables in the playbooks. I also think this block shouldn't be part of the enduro_sfa_pipelines loop and other improvements that we already discussed.
Better if we do those changes in other PRs after you are done with the splitting of roles you mentioned in Slack.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: