Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update upload and failed buckets configuration #3

Open
wants to merge 2 commits into
base: dev/add-preprocessing
Choose a base branch
from
Open

Update upload and failed buckets configuration #3

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8dcbfaf
Update upload configuration
jraddaoui Sep 4, 2024
e10147c
Use accessKey and secretKey in failed buckets
jraddaoui Sep 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 11 additions & 9 deletions templates/enduro.toml.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,26 +147,29 @@ bucket = "aips"
[failedPips]
endpoint = "{{ pipeline.watched_endpoint }}"
pathStyle = true
key = "{{ pipeline.watched_key }}"
secret = "{{ pipeline.watched_secret }}"
accessKey = "{{ pipeline.watched_key }}"
secretKey = "{{ pipeline.watched_secret }}"
region = "{{ pipeline.watched_region }}"
bucket = "failed-pips"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

failed-pips and failed-sips should be added to the data dictionary, as we do with the sips one

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really related with these changes and I don't want to introduce two new variables in the playbooks. I also think this block shouldn't be part of the enduro_sfa_pipelines loop and other improvements that we already discussed.

Better if we do those changes in other PRs after you are done with the splitting of roles you mentioned in Slack.


[failedSips]
endpoint = "{{ pipeline.watched_endpoint }}"
pathStyle = true
key = "{{ pipeline.watched_key }}"
secret = "{{ pipeline.watched_secret }}"
accessKey = "{{ pipeline.watched_key }}"
secretKey = "{{ pipeline.watched_secret }}"
region = "{{ pipeline.watched_region }}"
bucket = "failed-sips"

[upload]
maxSize = 102400000

[upload.bucket]
endpoint = "{{ pipeline.watched_endpoint }}"
pathStyle = true
key = "{{ pipeline.watched_key }}"
secret = "{{ pipeline.watched_secret }}"
pathStyle = "{{ pipeline.watched_pathStyle }}"
accessKey = "{{ pipeline.watched_key }}"
secretKey = "{{ pipeline.watched_secret }}"
region = "{{ pipeline.watched_region }}"
bucket = "sips"
bucket = "{{ pipeline.watched_bucket }}"

[watcher.embedded]
name = "{{ pipeline.watched_name }}"
Expand Down Expand Up @@ -231,4 +234,3 @@ disabled = true
[validation]
checksumsCheckEnabled = false
{% endif %}