Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added loading state and adjusted tweet height in TwitterTimelineEmbed #3256

Closed
wants to merge 2 commits into from
Closed

Added loading state and adjusted tweet height in TwitterTimelineEmbed #3256

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
74bcb94
Added loading state and adjusted tweet height in TwitterTimelineEmbed
oscar2104 Sep 25, 2024
71fe576
Fix twitter timeline
oscar2104 Sep 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion components/newsroom/Newsroom.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
import React, { useState } from 'react';

import { TwitterTimelineEmbed } from 'react-twitter-embed';

import { HeadingLevel, HeadingTypeStyle } from '@/types/typography/Heading';
Expand All @@ -11,10 +13,14 @@ import NewsroomArticle from './NewsroomArticle';
import NewsroomBlogPosts from './NewsroomBlogPosts';
import NewsroomYoutube from './NewsroomYoutube';


/**
* @description This component displays the latest updates, blog posts, news, and videos.
*/
export default function Newsroom() {

const [isLoaded, setIsLoaded] = useState(false);

return (
<>
<div className='mt-12 text-center' data-testid='Newsroom-main'>
Expand Down Expand Up @@ -78,7 +84,13 @@ export default function Newsroom() {
</div>
<div className='w-full px-2 md:w-1/2 md:pl-4 md:pr-0'>
<div className='mx-auto mt-8 w-full rounded-xl shadow-md md:mt-0' data-testid='Newsroom-Twitter'>
<TwitterTimelineEmbed sourceType='profile' screenName='AsyncAPISpec' options={{ tweetLimit: '2' }} />
{!isLoaded && <p> Loading Tweets... </p>}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a loader component present in the codebase. You should use that here.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it will look nicer, if the twitter timeline component while loading has the same height as that of the loaded twitter timeline component? 🤔

@akshatnema what's your suggestion on this?

<TwitterTimelineEmbed
sourceType='profile'
screenName='AsyncAPISpec'
options={{ height: '400' }}
onLoad={() => setIsLoaded(true)}
/>
</div>
</div>
</div>
Expand Down
Loading