Improve node attr handling when null, wrong type etc. #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… going into a non-nullable field. A cleaned up version of the changes for ME-5482
encryptededdy
requested review from
douglasmarques,
tchernykh and
nlam-atlassian
douglasmarques
previously approved these changes
Oct 13, 2024
|
Looks good, just need to update ktlint baseline |
tchernykh
previously approved these changes
Oct 13, 2024
nlam-atlassian
previously approved these changes
Oct 13, 2024
encryptededdy
dismissed stale reviews from nlam-atlassian, tchernykh, and douglasmarques
via
767ab34
nlam-atlassian
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle null/wrong type attrs more gracefully, especially when attr is going into a non-nullable field. I've cleaned up the tests and updated the javadocs/comments a bit compared to the changes for ME-5482 on the old repo, but the logic is the same.