Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve node attr handling when null, wrong type etc. #30

Merged
merged 3 commits into from
Oct 14, 2024
Merged

Improve node attr handling when null, wrong type etc. #30

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
de3e4a2
Handle null/wrong type attrs more gracefully, especially when attr is…
encryptededdy Oct 11, 2024
99652a5
Merge branch 'main' into ezhang2/handle-null-attrs
encryptededdy Oct 11, 2024
767ab34
Updated KtLint baseline for model
encryptededdy Oct 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
230 changes: 126 additions & 104 deletions model/config/ktlint/baseline.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,81 +236,83 @@
<error line="44" column="1" source="standard:no-consecutive-blank-lines" />
<error line="68" column="1" source="standard:no-empty-first-line-in-class-body" />
<error line="132" column="17" source="standard:multiline-expression-wrapping" />
<error line="165" column="40" source="standard:function-signature" />
<error line="165" column="54" source="standard:function-signature" />
<error line="165" column="72" source="standard:function-signature" />
<error line="205" column="9" source="standard:function-signature" />
<error line="205" column="72" source="standard:function-signature" />
<error line="230" column="17" source="standard:function-signature" />
<error line="230" column="35" source="standard:function-signature" />
<error line="230" column="49" source="standard:function-signature" />
<error line="348" column="19" source="standard:function-signature" />
<error line="348" column="35" source="standard:function-signature" />
<error line="348" column="50" source="standard:function-signature" />
<error line="348" column="75" source="standard:function-signature" />
<error line="368" column="14" source="standard:function-signature" />
<error line="368" column="41" source="standard:function-signature" />
<error line="368" column="61" source="standard:function-signature" />
<error line="385" column="18" source="standard:function-signature" />
<error line="385" column="29" source="standard:function-signature" />
<error line="385" column="44" source="standard:function-signature" />
<error line="392" column="15" source="standard:function-signature" />
<error line="392" column="26" source="standard:function-signature" />
<error line="392" column="55" source="standard:function-signature" />
<error line="392" column="86" source="standard:function-signature" />
<error line="408" column="17" source="standard:function-signature" />
<error line="408" column="28" source="standard:function-signature" />
<error line="408" column="37" source="standard:function-signature" />
<error line="408" column="49" source="standard:function-signature" />
<error line="450" column="35" source="standard:multiline-expression-wrapping" />
<error line="450" column="35" source="standard:function-signature" />
<error line="456" column="23" source="standard:function-signature" />
<error line="456" column="41" source="standard:function-signature" />
<error line="456" column="55" source="standard:function-signature" />
<error line="456" column="59" source="standard:multiline-expression-wrapping" />
<error line="456" column="59" source="standard:function-signature" />
<error line="465" column="22" source="standard:function-signature" />
<error line="465" column="33" source="standard:function-signature" />
<error line="465" column="42" source="standard:function-signature" />
<error line="465" column="52" source="standard:function-signature" />
<error line="476" column="22" source="standard:function-signature" />
<error line="476" column="33" source="standard:function-signature" />
<error line="476" column="42" source="standard:function-signature" />
<error line="476" column="56" source="standard:function-signature" />
<error line="531" column="24" source="standard:function-signature" />
<error line="531" column="35" source="standard:function-signature" />
<error line="531" column="44" source="standard:function-signature" />
<error line="531" column="60" source="standard:function-signature" />
<error line="531" column="85" source="standard:function-signature" />
<error line="569" column="25" source="standard:multiline-expression-wrapping" />
<error line="569" column="25" source="standard:function-signature" />
<error line="579" column="31" source="standard:multiline-expression-wrapping" />
<error line="579" column="31" source="standard:function-signature" />
<error line="583" column="61" source="standard:multiline-expression-wrapping" />
<error line="583" column="61" source="standard:function-signature" />
<error line="587" column="31" source="standard:function-signature" />
<error line="587" column="59" source="standard:function-signature" />
<error line="587" column="82" source="standard:function-signature" />
<error line="587" column="86" source="standard:multiline-expression-wrapping" />
<error line="587" column="86" source="standard:function-signature" />
<error line="614" column="1" source="standard:no-consecutive-blank-lines" />
<error line="616" column="1" source="standard:no-empty-first-line-in-class-body" />
<error line="619" column="22" source="standard:function-signature" />
<error line="619" column="38" source="standard:function-signature" />
<error line="619" column="57" source="standard:function-signature" />
<error line="619" column="80" source="standard:function-signature" />
<error line="633" column="25" source="standard:multiline-expression-wrapping" />
<error line="637" column="24" source="standard:multiline-expression-wrapping" />
<error line="644" column="43" source="standard:multiline-expression-wrapping" />
<error line="691" column="21" source="standard:function-signature" />
<error line="691" column="32" source="standard:function-signature" />
<error line="691" column="39" source="standard:function-signature" />
<error line="708" column="22" source="standard:function-signature" />
<error line="708" column="33" source="standard:function-signature" />
<error line="708" column="41" source="standard:function-signature" />
<error line="745" column="15" source="standard:function-signature" />
<error line="745" column="34" source="standard:function-signature" />
<error line="745" column="45" source="standard:function-signature" />
<error line="174" column="40" source="standard:function-signature" />
<error line="174" column="54" source="standard:function-signature" />
<error line="174" column="72" source="standard:function-signature" />
<error line="184" column="5" source="standard:blank-line-before-declaration" />
<error line="184" column="5" source="standard:spacing-between-declarations-with-comments" />
<error line="220" column="9" source="standard:function-signature" />
<error line="220" column="72" source="standard:function-signature" />
<error line="245" column="17" source="standard:function-signature" />
<error line="245" column="35" source="standard:function-signature" />
<error line="245" column="49" source="standard:function-signature" />
<error line="363" column="19" source="standard:function-signature" />
<error line="363" column="35" source="standard:function-signature" />
<error line="363" column="50" source="standard:function-signature" />
<error line="363" column="75" source="standard:function-signature" />
<error line="383" column="14" source="standard:function-signature" />
<error line="383" column="41" source="standard:function-signature" />
<error line="383" column="61" source="standard:function-signature" />
<error line="400" column="18" source="standard:function-signature" />
<error line="400" column="29" source="standard:function-signature" />
<error line="400" column="44" source="standard:function-signature" />
<error line="407" column="15" source="standard:function-signature" />
<error line="407" column="26" source="standard:function-signature" />
<error line="407" column="55" source="standard:function-signature" />
<error line="407" column="86" source="standard:function-signature" />
<error line="423" column="17" source="standard:function-signature" />
<error line="423" column="28" source="standard:function-signature" />
<error line="423" column="37" source="standard:function-signature" />
<error line="423" column="49" source="standard:function-signature" />
<error line="465" column="35" source="standard:multiline-expression-wrapping" />
<error line="465" column="35" source="standard:function-signature" />
<error line="471" column="23" source="standard:function-signature" />
<error line="471" column="41" source="standard:function-signature" />
<error line="471" column="55" source="standard:function-signature" />
<error line="471" column="59" source="standard:multiline-expression-wrapping" />
<error line="471" column="59" source="standard:function-signature" />
<error line="480" column="22" source="standard:function-signature" />
<error line="480" column="33" source="standard:function-signature" />
<error line="480" column="42" source="standard:function-signature" />
<error line="480" column="52" source="standard:function-signature" />
<error line="491" column="22" source="standard:function-signature" />
<error line="491" column="33" source="standard:function-signature" />
<error line="491" column="42" source="standard:function-signature" />
<error line="491" column="56" source="standard:function-signature" />
<error line="546" column="24" source="standard:function-signature" />
<error line="546" column="35" source="standard:function-signature" />
<error line="546" column="44" source="standard:function-signature" />
<error line="546" column="60" source="standard:function-signature" />
<error line="546" column="85" source="standard:function-signature" />
<error line="584" column="25" source="standard:multiline-expression-wrapping" />
<error line="584" column="25" source="standard:function-signature" />
<error line="594" column="31" source="standard:multiline-expression-wrapping" />
<error line="594" column="31" source="standard:function-signature" />
<error line="598" column="61" source="standard:multiline-expression-wrapping" />
<error line="598" column="61" source="standard:function-signature" />
<error line="602" column="31" source="standard:function-signature" />
<error line="602" column="59" source="standard:function-signature" />
<error line="602" column="82" source="standard:function-signature" />
<error line="602" column="86" source="standard:multiline-expression-wrapping" />
<error line="602" column="86" source="standard:function-signature" />
<error line="629" column="1" source="standard:no-consecutive-blank-lines" />
<error line="631" column="1" source="standard:no-empty-first-line-in-class-body" />
<error line="634" column="22" source="standard:function-signature" />
<error line="634" column="38" source="standard:function-signature" />
<error line="634" column="57" source="standard:function-signature" />
<error line="634" column="80" source="standard:function-signature" />
<error line="648" column="25" source="standard:multiline-expression-wrapping" />
<error line="652" column="24" source="standard:multiline-expression-wrapping" />
<error line="659" column="43" source="standard:multiline-expression-wrapping" />
<error line="706" column="21" source="standard:function-signature" />
<error line="706" column="32" source="standard:function-signature" />
<error line="706" column="39" source="standard:function-signature" />
<error line="723" column="22" source="standard:function-signature" />
<error line="723" column="33" source="standard:function-signature" />
<error line="723" column="41" source="standard:function-signature" />
<error line="760" column="15" source="standard:function-signature" />
<error line="760" column="34" source="standard:function-signature" />
<error line="760" column="45" source="standard:function-signature" />
</file>
<file name="src/commonMain/kotlin/com/atlassian/prosemirror/model/Platform.kt">
<error line="9" column="30" source="standard:function-signature" />
Expand Down Expand Up @@ -830,35 +832,55 @@
</file>
<file name="src/commonTest/kotlin/com/atlassian/prosemirror/model/NodeTest.kt">
<error line="5" column="1" source="standard:import-ordering" />
<error line="22" column="24" source="standard:multiline-expression-wrapping" />
<error line="23" column="13" source="standard:multiline-expression-wrapping" />
<error line="26" column="19" source="standard:multiline-expression-wrapping" />
<error line="29" column="22" source="standard:multiline-expression-wrapping" />
<error line="31" column="21" source="standard:multiline-expression-wrapping" />
<error line="37" column="25" source="standard:multiline-expression-wrapping" />
<error line="78" column="13" source="standard:function-signature" />
<error line="78" column="24" source="standard:function-signature" />
<error line="78" column="33" source="standard:function-signature" />
<error line="129" column="17" source="standard:function-signature" />
<error line="129" column="28" source="standard:function-signature" />
<error line="129" column="48" source="standard:function-signature" />
<error line="150" column="40" source="standard:multiline-expression-wrapping" />
<error line="150" column="40" source="standard:function-signature" />
<error line="162" column="42" source="standard:multiline-expression-wrapping" />
<error line="162" column="42" source="standard:function-signature" />
<error line="181" column="17" source="standard:multiline-expression-wrapping" />
<error line="203" column="17" source="standard:multiline-expression-wrapping" />
<error line="273" column="14" source="standard:function-signature" />
<error line="273" column="25" source="standard:function-signature" />
<error line="273" column="37" source="standard:function-signature" />
<error line="277" column="14" source="standard:function-signature" />
<error line="277" column="31" source="standard:function-signature" />
<error line="277" column="43" source="standard:function-signature" />
<error line="281" column="14" source="standard:function-signature" />
<error line="281" column="30" source="standard:function-signature" />
<error line="281" column="42" source="standard:function-signature" />
<error line="344" column="21" source="standard:multiline-expression-wrapping" />
<error line="356" column="25" source="standard:multiline-expression-wrapping" />
<error line="25" column="24" source="standard:multiline-expression-wrapping" />
<error line="26" column="13" source="standard:multiline-expression-wrapping" />
<error line="29" column="19" source="standard:multiline-expression-wrapping" />
<error line="32" column="22" source="standard:multiline-expression-wrapping" />
<error line="34" column="21" source="standard:multiline-expression-wrapping" />
<error line="36" column="48" source="standard:discouraged-comment-location" />
<error line="40" column="25" source="standard:multiline-expression-wrapping" />
<error line="81" column="13" source="standard:function-signature" />
<error line="81" column="24" source="standard:function-signature" />
<error line="81" column="33" source="standard:function-signature" />
<error line="132" column="17" source="standard:function-signature" />
<error line="132" column="28" source="standard:function-signature" />
<error line="132" column="48" source="standard:function-signature" />
<error line="153" column="40" source="standard:multiline-expression-wrapping" />
<error line="153" column="40" source="standard:function-signature" />
<error line="165" column="42" source="standard:multiline-expression-wrapping" />
<error line="165" column="42" source="standard:function-signature" />
<error line="184" column="17" source="standard:multiline-expression-wrapping" />
<error line="206" column="17" source="standard:multiline-expression-wrapping" />
<error line="276" column="14" source="standard:function-signature" />
<error line="276" column="25" source="standard:function-signature" />
<error line="276" column="37" source="standard:function-signature" />
<error line="280" column="14" source="standard:function-signature" />
<error line="280" column="31" source="standard:function-signature" />
<error line="280" column="43" source="standard:function-signature" />
<error line="284" column="14" source="standard:function-signature" />
<error line="284" column="30" source="standard:function-signature" />
<error line="284" column="42" source="standard:function-signature" />
<error line="347" column="21" source="standard:multiline-expression-wrapping" />
<error line="359" column="25" source="standard:multiline-expression-wrapping" />
<error line="372" column="17" source="standard:multiline-expression-wrapping" />
<error line="372" column="38" source="standard:multiline-expression-wrapping" />
<error line="372" column="38" source="standard:wrapping" />
<error line="374" column="9" source="standard:wrapping" />
<error line="383" column="17" source="standard:multiline-expression-wrapping" />
<error line="383" column="38" source="standard:multiline-expression-wrapping" />
<error line="383" column="38" source="standard:wrapping" />
<error line="386" column="9" source="standard:wrapping" />
<error line="398" column="17" source="standard:multiline-expression-wrapping" />
<error line="398" column="38" source="standard:multiline-expression-wrapping" />
<error line="398" column="38" source="standard:wrapping" />
<error line="401" column="9" source="standard:wrapping" />
<error line="412" column="17" source="standard:multiline-expression-wrapping" />
<error line="412" column="38" source="standard:multiline-expression-wrapping" />
<error line="412" column="38" source="standard:wrapping" />
<error line="414" column="9" source="standard:wrapping" />
<error line="417" column="31" source="standard:multiline-expression-wrapping" />
<error line="423" column="66" source="standard:multiline-expression-wrapping" />
<error line="423" column="66" source="standard:function-signature" />
</file>
<file name="src/iosMain/kotlin/com/atlassian/prosemirror/model/Platform.ios.kt">
<error line="12" column="30" source="standard:function-signature" />
Expand Down
Loading