Closes #226 - metadata is no longer inferred on xportr_write

[averissimo]

Thank you for your Pull Request!

We have developed a Pull Request template to aid you and our reviewers. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the xportr codebase remains robust and consistent.

The scope of {xportr}

{xportr}'s scope is to enable R users to write out submission compliant xpt files that can be delivered to a Health Authority or to downstream validation software programs. We see labels, lengths, types, ordering and formats from a dataset specification object (SDTM and ADaM) as being our primary focus. We also see messaging and warnings to users around applying information from the specification file as a primary focus. Please make sure your Pull Request meets this scope of {xportr}. If your Pull Request moves beyond this scope, please get in touch with the {xportr} team on slack or create an issue to discuss.

Please check off each task box as an acknowledgment that you completed the task. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the devel branch until you have checked off each task.

Changes Description

• Closes Bug: metadata should not be infered in xportr_write #226
• Revert change in Closes #175 Adds assertions to exported functions #190
  • xportr_write didn't infer metadata parameter from data_frame (this behavior is restored with this PR)

Task List

• The spirit of xportr is met in your Pull Request
• Place Closes #<insert_issue_number> into the beginning of your Pull Request Title (Use Edit button in top-right if you need to update)
• Summary of changes filled out in the above Changes Description. Can be removed or left blank if changes are minor/self-explanatory.
• Code is formatted according to the tidyverse style guide. Use styler package and functions to style files accordingly.
• Updated relevant unit tests or have written new unit tests. See our Wiki for conventions used in this package.
• Creation/updated relevant roxygen headers and examples. See our Wiki for conventions used in this package.
• Run devtools::document() so all .Rd files in the man folder and the NAMESPACE file in the project root are updated appropriately
• Run pkgdown::build_site() and check that all affected examples are displayed correctly and that all new/updated functions occur on the "Reference" page.
• Update NEWS.md if the changes pertain to a user-facing function (i.e. it has an @export tag) or documentation aimed at users (rather than developers)
• Make sure that the package version in the NEWS.md and DESCRIPTION file is same. Don't worry about updating the version because it will be auto-updated using the vbump.yaml CI.
• Address any updates needed for vignettes and/or templates
• Link the issue Development Panel so that it closes after successful merging.
• Fix merge conflicts
• Pat yourself on the back for a job well done! Much love to your accomplishment!

[averissimo]

metadata parameter should be the same as xportr_df_label (Metacore or with dataset name)

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9836f8b) 100.00% compared to head (640cdac) 100.00%.
Report is 2 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff            @@
##              main      #227   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           13        13           
  Lines          613       612    -1     
=========================================
- Hits           613       612    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[averissimo]

Alternatively, we could infer *only* if it's a metacore instance.

Suggested change

	# metadata should not be inferred from the data frame if it is not provided
	# by the user.
	# metadata should only be inferred from the data frame if it is a `Metacore` object
	metadata_tmp <- metadata %||% attr(.df, "_xportr.df_metadata_")
	if (inherits(metadata_tmp, "Metacore")) metadata <- metadata_tmp

[bms63]

Thank you Andre!! @cpiraux I think this might fix the length PR as well