Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #226 - metadata is no longer inferred on xportr_write #227

Merged
merged 1 commit into from
Jan 29, 2024

fix/revert: metadata is no longer inferred

640cdac
Select commit
Loading
Failed to load commit list.
Merged

Closes #226 - metadata is no longer inferred on xportr_write #227

fix/revert: metadata is no longer inferred
640cdac
Select commit
Loading
Failed to load commit list.
Task list completed / task-list-completed succeeded Jan 29, 2024 in 0s

14 / 14 tasks completed

All tasks have been completed

Details

Required Tasks

Task Status
Closes #226 Incomplete
xportr_write didn't infer metadata parameter from data_frame (this behavior is restored with this PR) Incomplete
The spirit of xportr is met in your Pull Request Completed
Place Closes #<insert_issue_number> into the beginning of your Pull Request Title (Use Edit button in top-right if you need to update) Completed
Summary of changes filled out in the above Changes Description. Can be removed or left blank if changes are minor/self-explanatory. Completed
Code is formatted according to the tidyverse style guide. Use styler package and functions to style files accordingly. Completed
Updated relevant unit tests or have written new unit tests. See our Wiki for conventions used in this package. Completed
Creation/updated relevant roxygen headers and examples. See our Wiki for conventions used in this package. Completed
Run devtools::document() so all .Rd files in the man folder and the NAMESPACE file in the project root are updated appropriately Completed
Run pkgdown::build_site() and check that all affected examples are displayed correctly and that all new/updated functions occur on the "Reference" page. Completed
Update NEWS.md if the changes pertain to a user-facing function (i.e. it has an @export tag) or documentation aimed at users (rather than developers) Completed
Make sure that the package version in the NEWS.md and DESCRIPTION file is same. Don't worry about updating the version because it will be auto-updated using the vbump.yaml CI. Completed
Address any updates needed for vignettes and/or templates Completed
Link the issue Development Panel so that it closes after successful merging. Completed
Fix merge conflicts Completed
Pat yourself on the back for a job well done! Much love to your accomplishment! Completed