Use dots for OTLP labels #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arendjr
commented
Nov 7, 2023
| @@ -2,6 +2,7 @@ | |||
| "compilerOptions": { | |||
| "allowImportingTsExtensions": true, | |||
| "lib": ["DOM", "ESNext"], | |||
| "module": "ES2022", | |||
There was a problem hiding this comment.
This merely resolved a warning in the IDE.
stephlow
approved these changes
Nov 8, 2023
keturiosakys
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merely changes all the label constants to use dots instead of underscores, so they get submitted to OTLP endpoints according to the 1.0 spec.
I didn't have to change anything for the Prometheus exporters, because it appears the libraries do the translation back to underscores for us (and we have test coverage for it).
Implements AM-46.