Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use dots for OTLP labels #140

Merged
merged 1 commit into from
Nov 13, 2023
Merged

Use dots for OTLP labels #140

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions packages/autometrics/src/constants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,21 +8,21 @@ export const GAUGE_NAME = "function.calls.concurrent" as const;
export const BUILD_INFO_NAME = "build_info" as const;

// Labels
export const AUTOMETRICS_VERSION_LABEL = "autometrics_version" as const;
export const AUTOMETRICS_VERSION_LABEL = "autometrics.version" as const;
export const BRANCH_LABEL = "branch" as const;
export const CALLER_FUNCTION_LABEL = "caller_function" as const;
export const CALLER_MODULE_LABEL = "caller_module" as const;
export const CALLER_FUNCTION_LABEL = "caller.function" as const;
export const CALLER_MODULE_LABEL = "caller.module" as const;
export const COMMIT_LABEL = "commit" as const;
export const FUNCTION_LABEL = "function" as const;
export const MODULE_LABEL = "module" as const;
export const OBJECTIVE_NAME_LABEL = "objective_name" as const;
export const OBJECTIVE_PERCENTILE_LABEL = "objective_percentile" as const;
export const OBJECTIVE_NAME_LABEL = "objective.name" as const;
export const OBJECTIVE_PERCENTILE_LABEL = "objective.percentile" as const;
export const OBJECTIVE_LATENCY_THRESHOLD_LABEL =
"objective_latency_threshold" as const;
export const REPOSITORY_URL_LABEL = "repository_url" as const;
export const REPOSITORY_PROVIDER_LABEL = "repository_provider" as const;
"objective.latency_threshold" as const;
export const REPOSITORY_URL_LABEL = "repository.url" as const;
export const REPOSITORY_PROVIDER_LABEL = "repository.provider" as const;
export const RESULT_LABEL = "result" as const;
export const SERVICE_NAME_LABEL = "service_name" as const;
export const SERVICE_NAME_LABEL = "service.name" as const;
export const VERSION_LABEL = "version" as const;

// Descriptions
Expand Down
8 changes: 4 additions & 4 deletions packages/autometrics/tests/__snapshots__/otlpHttpExporter.test.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,12 @@ export const snapshot = {};

snapshot[`OTLP/HTTP exporter 1`] = `
{
caller_function: "",
caller_module: "",
"caller.function": "",
"caller.module": "",
"objective.name": "",
"objective.percentile": "",
function: "foo",
module: "/packages/autometrics/tests/otlpHttpExporter.test.ts",
objective_name: "",
objective_percentile: "",
result: "ok",
}
`;
1 change: 1 addition & 0 deletions tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
"compilerOptions": {
"allowImportingTsExtensions": true,
"lib": ["DOM", "ESNext"],
"module": "ES2022",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This merely resolved a warning in the IDE.

"moduleResolution": "Bundler",
"noEmit": true,
"paths": {
Expand Down
Loading