-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(autoware_map_msgs): modify pcd metadata msg #96
refactor(autoware_map_msgs): modify pcd metadata msg #96
Conversation
…etaData Signed-off-by: Yamato Ando <[email protected]>
Signed-off-by: Yamato Ando <[email protected]>
Signed-off-by: Yamato Ando <[email protected]>
Signed-off-by: Yamato Ando <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@youtalk san, @mitsudome-r san, since we switched to version based repo tracking, this needs to be released and updated.
I think we will need to formally do a release for every PR in these repositories with versions, is that alright? |
…utowarefoundation#96)" This reverts commit 06ceea7. Signed-off-by: Ryohsuke Mitsudome <[email protected]>
…96)" (#98) revert: Revert "refactor(autoware_map_msgs): modify pcd metadata msg (#96)" This reverts commit 06ceea7. Signed-off-by: Ryohsuke Mitsudome <[email protected]>
@xmfcx The core packages' version control partially prevents the API breakage which I expected. @YamatoAndo Generally speaking, we should not casually break the API. Please reconsider your changes. |
This was reverted by: |
Description
To match the structure of the Lanelet2 metadata message, I will modify the PointCloud metadata message. #81 (comment)
PointCloudMapCellMetaData.msg
PointCloudMapCellMetaDataWithID.msg
PointCloudMapCellMetaDataWithID.msg
toPointCloudMapCellWithMetaData.msg
Tests performed
Not applicable.
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.