Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(autoware_map_msgs): modify pcd metadata msg #96

Conversation

YamatoAndo
Copy link
Contributor

Description

To match the structure of the Lanelet2 metadata message, I will modify the PointCloud metadata message. #81 (comment)

  • add cell_id to PointCloudMapCellMetaData.msg
  • delete PointCloudMapCellMetaDataWithID.msg
  • rename PointCloudMapCellMetaDataWithID.msg to PointCloudMapCellWithMetaData.msg

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Yamato Ando <[email protected]>
Signed-off-by: Yamato Ando <[email protected]>
Signed-off-by: Yamato Ando <[email protected]>
@YamatoAndo YamatoAndo marked this pull request as ready for review July 10, 2024 08:41
Copy link
Collaborator

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mitsudome-r mitsudome-r merged commit 06ceea7 into autowarefoundation:main Jul 24, 2024
8 of 9 checks passed
@xmfcx
Copy link
Collaborator

xmfcx commented Jul 24, 2024

@youtalk san, @mitsudome-r san, since we switched to version based repo tracking, this needs to be released and updated.

I think we will need to formally do a release for every PR in these repositories with versions, is that alright?

mitsudome-r added a commit to mitsudome-r/autoware_msgs that referenced this pull request Jul 25, 2024
mitsudome-r added a commit that referenced this pull request Jul 25, 2024
…96)" (#98)

revert: Revert "refactor(autoware_map_msgs): modify pcd metadata msg (#96)"

This reverts commit 06ceea7.

Signed-off-by: Ryohsuke Mitsudome <[email protected]>
@youtalk
Copy link
Member

youtalk commented Jul 25, 2024

@xmfcx The core packages' version control partially prevents the API breakage which I expected.
Instead we need to release the package by semantic versioning.

@YamatoAndo Generally speaking, we should not casually break the API. Please reconsider your changes.

@xmfcx
Copy link
Collaborator

xmfcx commented Jul 29, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants