-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(lidar_apollo_segmentation_tvm)!: remove packages #5022
feat(lidar_apollo_segmentation_tvm)!: remove packages #5022
Conversation
Signed-off-by: kminoda <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once autowarefoundation/autoware.universe#8150 was merged, it would be time to review.
@youtalk Thanks. Let me convert this to a draft at this moment. |
Both |
@youtalk Now ready to get your review. Thanks! 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
It is also worth to reduce the container image sizes. Nice work.
@youtalk Thanks. Would you merge this? I don't have the permission to do so. |
Memo:
|
@kminoda san, it's not your fault,
Either we switch them to main branch or make a new release for autoware_msgs and update the tag here. So updating something would normally require 2 PR (e.g. universe and msgs). Now it will require 3 or 4 PRs (for autoware.repos and maybe for version update for msgs) cc. @youtalk @mitsudome-r |
@xmfcx Thanks. So is there anything I can do? Or should I just wait until those tasks are done? |
Yes, we need to wait for this task for now. It's approved and will be merged anyways. |
@kminoda Congrats finally! |
Description
Solves autowarefoundation/autoware.universe#8175
See autowarefoundation/autoware.universe#7996
Tests performed
See autowarefoundation/autoware.universe#7996
Effects on system behavior
See autowarefoundation/autoware.universe#7996
Interface changes
See autowarefoundation/autoware.universe#7996
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.