Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tags] Prevent duplicate tags in root volume of the head node. #6241

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

gmarciani
Copy link
Contributor

Description of changes

Prevent duplicated tags in the head node launch template.

Why there were duplicates?
Because get_custom_tags() returns custom tags and a subset of default tags.
The long term fix would be to fix get_custom_tags() but since it is extensively used, this would imply a refactoring with a low ROI at the moment.

Tests

  • Create a cluster with this change and verified that the tag parallelcluster:cluster-name is not duplicated in the head node root volume (it used to be before this change).

References

  • Link to impacted open issues.
  • Link to related PRs in other packages (i.e. cookbook, node).
  • Link to documentation useful to understand the changes.

Checklist

  • Make sure you are pointing to the right branch.
  • If you're creating a patch for a branch other than develop add the branch name as prefix in the PR title (e.g. [release-3.6]).
  • Check all commits' messages are clear, describing what and why vs how.
  • Make sure to have added unit tests or integration tests to cover the new/modified code.
  • Check if documentation is impacted by this change.

Please review the guidelines for contributing and Pull Request Instructions.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant