Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tags] Prevent duplicate tags in root volume of the head node. #6241

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ CHANGELOG
- Consider Compute fleet clean-up completed during cluster deletion when instances are either in shutting-down or terminated state.
This is to avoid cluster deletion failure for instance types with longer termination cycles.
- Allow cloudwatch dashboard to be enabled and alarms to be disabled in the `Monitoring` section of the cluster config.
- Fix a bug causing duplicated tags in the head node launch template.

**CHANGES**
- Upgrade Cinc Client to version to 18.4.12 from 18.2.7.
Expand Down
8 changes: 7 additions & 1 deletion cli/src/pcluster/templates/cluster_stack.py
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,7 @@
apply_permissions_boundary,
convert_deletion_policy,
create_hash_suffix,
dict_to_cfn_tags,
get_cloud_watch_logs_policy_statement,
get_cloud_watch_logs_retention_days,
get_common_user_data_env,
Expand Down Expand Up @@ -1240,7 +1241,12 @@ def _add_head_node(self):
tag_specifications=[
ec2.CfnLaunchTemplate.TagSpecificationProperty(
resource_type="volume",
tags=get_default_volume_tags(self._stack_name, "HeadNode") + get_custom_tags(self.config),
tags=dict_to_cfn_tags(
{
**get_default_volume_tags(self._stack_name, "HeadNode", raw_dict=True),
**get_custom_tags(self.config, raw_dict=True),
}
),
),
],
),
Expand Down
Loading