Change the base config's import/order rule so the unknown import type now fills the last import group slot
#14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…type now fills the last import group slot
mangs
force-pushed
the
tweak-import-groups
branch
from
78c404f
to
0d20e44
Compare
mangs
changed the title
import/order rule so the unknown import type is lastimport/order rule so the unknown import type now fills the last import group slot
mangs
commented
Jan 11, 2024
| @@ -39,9 +39,10 @@ | |||
| { | |||
| "groups": [ | |||
| ["builtin", "external"], | |||
| ["internal", "unknown", "parent", "sibling", "index"], | |||
| ["index", "internal", "parent", "sibling"], | |||
There was a problem hiding this comment.
Put these in alphabetical order so it's easier to read them from left to right
| ["type"], | ||
| ["object"] | ||
| ["object"], | ||
| ["unknown"] |
There was a problem hiding this comment.
The documentation for the order rule added examples of all group types except for unknown, so now that it's clear what each group type does, rather than have unknown mixed into the Internal Imports group, move it to its own group. Skimming through the ESLint plugin code doesn't reveal any obvious details either.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
package.jsonandpackage-lock.jsonfollowing Semantic VersioningChanges Included
1.2.1import/orderrule so theunknownimport type now fills the last import group slot