Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change the base config's import/order rule so the unknown import type now fills the last import group slot #14

Merged
merged 2 commits into from
Jan 12, 2024
Merged

Change the base config's import/order rule so the unknown import type now fills the last import group slot #14

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0d20e44
Change the base config's `import/order` rule so the `unknown` import …
mangs Jan 11, 2024
1072e15
update changelog
mangs Jan 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# Changelog

## 1.2.1

- Change the base config's `import/order` rule so the `unknown` import type now fills the last import group slot

## 1.2.0

- Testing added using example code for each configuration to verify correctness during continuous integration
Expand Down
5 changes: 3 additions & 2 deletions lib/eslintBaseConfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,9 +39,10 @@
{
"groups": [
["builtin", "external"],
["internal", "unknown", "parent", "sibling", "index"],
["index", "internal", "parent", "sibling"],
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Put these in alphabetical order so it's easier to read them from left to right

["type"],
["object"]
["object"],
["unknown"]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The documentation for the order rule added examples of all group types except for unknown, so now that it's clear what each group type does, rather than have unknown mixed into the Internal Imports group, move it to its own group. Skimming through the ESLint plugin code doesn't reveal any obvious details either.

],
"newlines-between": "always"
}
Expand Down
63 changes: 33 additions & 30 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@babbel/eslint-config",
"version": "1.2.0",
"version": "1.2.1",
"author": "Eric L. Goldstein <[email protected]>",
"description": "Hierarchical ESLint configuration collection that intends to be simple to use, layered, and shared with others",
"keywords": [
Expand Down