Fix incorrect state when hostname resolution fails #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR is much less ambitious than beam-telemetry#94. In this case, we just fix the issue when the process is already started, but an error in the resolution of the hostname leads to an incorrect internal state. Without this patch, the `new_state` will be `:ok`, as that is the return from the logger function. Afterwards, when going to the `terminate` callback, then we try to call `EventHandler.detach(state.handler_ids)`, which translates to `EventHandler.detach(:ok.handler_ids)` and fails
|
👍 |
|
@arkgil could you review this PR, this enables us to move away from forked version of the library |
arkgil
approved these changes
Jun 2, 2024
|
Thanks! |
juanperi
deleted the
fix/hostname-resolution-error-leads-to-incorrect-state
branch
juanperi
restored the
fix/hostname-resolution-error-leads-to-incorrect-state
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is much less ambitious than #94 (and so I expect it would be an easier merge). In this case, we just fix the issue when the process is already started, but an error in the resolution of the hostname leads to an incorrect internal state.
Without this patch, the
new_statewill be:ok, as that is the return from the logger function.Afterwards, when going to the
terminatecallback, then we try to callEventHandler.detach(state.handler_ids), which translates toEventHandler.detach(:ok.handler_ids)and fails.