Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect state when hostname resolution fails #96

Commits on May 21, 2024

  1. Fix incorrect state when hostname resolution fails

    This PR is much less ambitious than beam-telemetry#94. In this case, we just fix the
    issue when the process is already started, but an error in the
    resolution of the hostname leads to an incorrect internal state.
    
    Without this patch, the `new_state` will be `:ok`, as that is the return
    from the logger function.
    Afterwards, when going to the `terminate` callback, then we try to call
    `EventHandler.detach(state.handler_ids)`, which translates to
    `EventHandler.detach(:ok.handler_ids)` and fails
    juanperi committed May 21, 2024
    Configuration menu
    Copy the full SHA
    9a9e097 View commit details
    Browse the repository at this point in the history