Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SPA06 and SPL07 baro support for Kakute series FC #604

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions configs/KAKUTEF4/config.h
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@
#define USE_ACC_SPI_ICM20689
#define USE_BARO
#define USE_BARO_BMP280
#define USE_BARO_DPS310
Comment on lines 35 to +37
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#define USE_BARO
#define USE_BARO_BMP280
#define USE_BARO_DPS310

This FC has no I2C resources assigned, so these defines should not be included.

#define USE_FLASH
#define USE_FLASH_W25Q128FV
#define USE_MAX7456
Expand Down
1 change: 1 addition & 0 deletions configs/KAKUTEF4V2/config.h
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@
#define USE_GYRO_SPI_ICM20689
#define USE_ACC_SPI_ICM20689
#define USE_BARO_BMP280
#define USE_BARO_DPS310
#define USE_FLASH
#define USE_FLASH_W25Q128FV
#define USE_MAX7456
Expand Down
1 change: 1 addition & 0 deletions configs/KAKUTEF7/config.h
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@
#define USE_GYRO_SPI_MPU6000
#define USE_ACC_SPI_MPU6000
#define USE_BARO_BMP280
#define USE_BARO_DPS310
Comment on lines 35 to +36
Copy link
Contributor

@ot0tot ot0tot Nov 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#define USE_BARO_BMP280
#define USE_BARO_DPS310
#define USE_BARO
#define USE_BARO_BMP280
#define USE_BARO_DPS310

Also remove these lines further down

#define USE_BARO
#define DEFAULT_BARO_DEVICE BARO_BMP280

#define USE_MAX7456
#define USE_SDCARD

Expand Down
1 change: 1 addition & 0 deletions configs/KAKUTEF7HDV/config.h
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@
#define USE_GYRO
#define USE_GYRO_SPI_MPU6000
#define USE_BARO_BMP280
#define USE_BARO_DPS310
Comment on lines 33 to +34
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment as KAKUTEF7 target

Suggested change
#define USE_BARO_BMP280
#define USE_BARO_DPS310
#define USE_BARO
#define USE_BARO_BMP280
#define USE_BARO_DPS310

and remove

#define USE_BARO
#define DEFAULT_BARO_DEVICE BARO_BMP280

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also remove DEFAULT_BARO defines in other targets.

#define USE_SDCARD

#define BEEPER_PIN PD15
Expand Down
1 change: 1 addition & 0 deletions configs/KAKUTEF7MINI/config.h
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@
#define USE_GYRO_SPI_ICM20689
#define USE_BARO
#define USE_BARO_BMP280
#define USE_BARO_DPS310
#define USE_FLASH
#define USE_FLASH_W25Q128FV
#define USE_MAX7456
Expand Down
1 change: 1 addition & 0 deletions configs/KAKUTEF7MINIV3/config.h
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@
#define USE_GYRO_SPI_ICM42688P
#define USE_BARO
#define USE_BARO_BMP280
#define USE_BARO_DPS310
#define USE_FLASH
#define USE_FLASH_W25Q128FV
#define USE_MAX7456
Expand Down
1 change: 1 addition & 0 deletions configs/KAKUTEF7V2/config.h
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@
#define USE_ACC_SPI_MPU6000
#define USE_GYRO_SPI_MPU6000
#define USE_BARO_BMP280
#define USE_BARO_DPS310
#define USE_MAX7456
#define USE_SDCARD

Expand Down
1 change: 1 addition & 0 deletions configs/KAKUTEH7MINI/config.h
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@
#define USE_ACC_SPI_ICM42688P
#define USE_ACCGYRO_BMI270
#define USE_BARO_BMP280
#define USE_BARO_DPS310
#define USE_FLASH
#define USE_FLASH_W25N01G
#define USE_FLASH_W25Q128FV
Expand Down
1 change: 1 addition & 0 deletions configs/KAKUTEH7V2/config.h
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@
#define USE_ACC
#define USE_ACCGYRO_BMI270
#define USE_BARO_BMP280
#define USE_BARO_DPS310
#define USE_FLASH
#define USE_FLASH_W25N01G
#define USE_MAX7456
Expand Down