Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

close #550 #563

Merged
merged 4 commits into from
Mar 11, 2024
Merged

close #550 #563

merged 4 commits into from
Mar 11, 2024

Conversation

liampauling
Copy link
Member

update create socket for py3.12

update create socket for py3.12
@synapticarbors
Copy link
Contributor

I think you need to add setuptools as an explicit dependency. You might also consider moving to a more modern setup using a pyproject.toml with a build-system defined:
https://packaging.python.org/en/latest/guides/writing-pyproject-toml/
https://packaging.python.org/en/latest/guides/modernize-setup-py-project/

@liampauling
Copy link
Member Author

Yeah that isn't a concern re this change

@synapticarbors
Copy link
Contributor

I agree, that moving to a different build system is secondary, but I think you do need to add setuptools to your build environment. See https://docs.python.org/3/whatsnew/3.12.html and under "Important deprecations, removals or restrictions" -> gh-95299

@liampauling liampauling changed the base branch from master to release/2.20.0 March 11, 2024 09:24
@liampauling liampauling merged commit 4bfad02 into release/2.20.0 Mar 11, 2024
11 checks passed
@liampauling liampauling deleted the tasl/550-socket-3.12 branch March 11, 2024 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants