close #550

.github/workflows/test.yml

@@ -11,7 +11,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        python-version: ['3.8', '3.9', '3.10', '3.11']
+        python-version: ['3.8', '3.9', '3.10', '3.11', '3.12']
 
     steps:
     - uses: actions/checkout@v2
@@ -21,10 +21,6 @@ jobs:
       with:
         python-version: ${{ matrix.python-version }}
 
-    - name: Check setup.py
-      run: |
-        python setup.py check
-
     - name: Install dependencies
       run: |
         pip install -r requirements.txt
@@ -47,7 +43,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        python-version: ['3.8', '3.9', '3.10', '3.11']
+        python-version: ['3.8', '3.9', '3.10', '3.11', '3.12']
 
     steps:
       - uses: actions/checkout@v2
@@ -89,7 +85,7 @@ jobs:
 
     - name: Build package and docs
       run: |
-        python setup.py sdist bdist_wheel
+        python -m build
         twine check dist/*
         mkdocs build
 

README.md

@@ -14,7 +14,7 @@ Lightweight, super fast (uses C and Rust libraries) pythonic wrapper for [Betfai
 
 [join betcode slack group](https://join.slack.com/t/betcode-org/shared_invite/zt-25yz6dt1y-LHya5VzHLOzN3RZEQrSnrA)
 
-Currently tested on Python 3.8, 3.9, 3.10 and 3.11.
+Currently tested on Python 3.8, 3.9, 3.10, 3.11 and 3.12.
 
 # installation
 

betfairlightweight/resources/racecardresources.py

@@ -240,7 +240,7 @@ def __init__(
         surface=None,
         ratingSymbol=None,
         ratingvalue=None,
-        **kwargs
+        **kwargs,
     ):
         self.racing_type = racingType
         self.surface = surface
@@ -303,7 +303,7 @@ def __init__(
         preRaceMasterRating=None,
         preRaceWeightAdjustedMasterRating=None,
         seasonMasterRating=None,
-        **kwargs
+        **kwargs,
     ):
         self.age = age
         self.comment = comment

betfairlightweight/streaming/betfairstream.py

@@ -211,8 +211,11 @@ def _create_socket(self) -> socket.socket:
         """Creates ssl socket, connects to stream api and
         sets timeout.
         """
-        s = socket.socket(socket.AF_INET, socket.SOCK_STREAM)
-        s = ssl.wrap_socket(s)
+        context = ssl.SSLContext(ssl.PROTOCOL_TLS)
+        context.verify_mode = ssl.CERT_NONE
+        s = context.wrap_socket(
+            socket.socket(socket.AF_INET, socket.SOCK_STREAM), server_hostname=self.host
+        )
         s.settimeout(self.timeout)
         s.connect((self.host, self.__port))
         return s

betfairlightweight/streaming/cache.py

@@ -443,7 +443,7 @@ def __init__(
         rc: str = None,
         lsrc: str = None,
         cd: int = None,
-        **kwargs
+        **kwargs,
     ):
         self.publish_time = publish_time
         self.bet_id = id
@@ -487,9 +487,11 @@ def serialise(
             "marketId": market_id,
             "matchedDate": self._matched_date_string,
             "orderType": StreamingOrderType[self.order_type].value,
-            "persistenceType": StreamingPersistenceType[self.persistence_type].value
-            if self.persistence_type
-            else None,
+            "persistenceType": (
+                StreamingPersistenceType[self.persistence_type].value
+                if self.persistence_type
+                else None
+            ),
             "placedDate": self._placed_date_string,
             "priceSize": {"price": self.price, "size": self.size},
             "regulatorAuthCode": self.regulator_auth_code,

betfairlightweight/streaming/stream.py

@@ -246,7 +246,6 @@ def _process(self, data: list, publish_time: int) -> bool:
 
 
 class RaceStream(BaseStream):
-
     """
     Cache contains latest update:
         marketId: RaceCache

pyproject.toml

@@ -0,0 +1,50 @@
+[build-system]
+requires = ["hatchling"]
+build-backend = "hatchling.build"
+
+[project]
+name = "betfairlightweight"
+description = "Lightweight python wrapper for Betfair API-NG"
+readme = "README.md"
+license = {file = "LICENSE"}
+requires-python = ">=3.8"
+authors = [
+    { name = "Liam Pauling", email = "[email protected]" },
+]
+classifiers = [
+    "License :: OSI Approved :: MIT License",
+    "Operating System :: OS Independent",
+    "Programming Language :: Python :: 3.8",
+    "Programming Language :: Python :: 3.9",
+    "Programming Language :: Python :: 3.10",
+    "Programming Language :: Python :: 3.11",
+    "Programming Language :: Python :: 3.12",
+]
+dependencies = [
+    "requests<2.32.0",
+]
+dynamic = ["version"]
+
+[project.optional-dependencies]
+speed = [
+    "ciso8601==2.3.0",
+    "orjson==3.9.9",
+]
+test = [
+    "black==23.10.0",
+    "coverage",
+    "mkdocs",
+    "mkdocs-material",
+    "twine",
+    "wheel",
+]
+
+[project.urls]
+Homepage = "https://github.com/betcode-org"
+Documentation = "https://betcode-org.github.io/betfair/"
+Repository = "https://github.com/betcode-org/betfair.git"
+"Bug Tracker" = "https://github.com/betcode-org/betfair/issues"
+Changelog = "https://github.com/betcode-org/betfair/blob/master/HISTORY.rst"
+
+[tool.hatch.version]
+path = "betfairlightweight/__version__.py"

requirements-test.txt

@@ -1,5 +1,5 @@
 # Tests & Linting
-black==23.10.0
+black==24.2.0
 coverage
 
 # Documentation

tests/test_betfairstream.py

@@ -1,6 +1,7 @@
 import unittest
 import socket
 import time
+import ssl
 import threading
 from unittest import mock
 
@@ -252,13 +253,23 @@ def test_subscribe_to_cricket_matches(self, mock_send):
             self.betfair_stream._unique_id, "cricketSubscription"
         )
 
-    @mock.patch("ssl.wrap_socket")
+    @mock.patch("ssl.SSLContext")
     @mock.patch("socket.socket")
-    def test_create_socket(self, mock_socket, mock_wrap_socket):
+    def test_create_socket(self, mock_socket, mock_ssl_context):
         self.betfair_stream._create_socket()
 
         mock_socket.assert_called_with(socket.AF_INET, socket.SOCK_STREAM)
-        assert mock_wrap_socket.call_count == 1
+        self.assertEqual(mock_ssl_context.call_count, 1)
+        mock_ssl_context.assert_called_with(ssl.PROTOCOL_TLS)
+        mock_ssl_context.return_value.wrap_socket.assert_called_with(
+            mock_socket.return_value, server_hostname="stream-api.betfair.com"
+        )
+        mock_ssl_context.return_value.wrap_socket.return_value.settimeout.assert_called_with(
+            6
+        )
+        mock_ssl_context.return_value.wrap_socket.return_value.connect.assert_called_with(
+            ("stream-api.betfair.com", 443)
+        )
 
     @mock.patch(
         "betfairlightweight.streaming.betfairstream.BetfairStream._data",

tests/test_cache.py

@@ -697,7 +697,7 @@ def test_update_cache_new(self, mock_order_book_runner):
                     self.order_book_cache.market_id,
                     1234,
                     self.order_book_cache.lightweight,
-                    **order_changes
+                    **order_changes,
                 )
 
     def test_update_cache_closed(self):