Five refactorings

src/main/java/org/bitsofinfo/hazelcast/discovery/docker/swarm/SystemPrintLogger.java

@@ -8,10 +8,9 @@
 import java.util.logging.Level;
 import java.util.logging.LogRecord;
 
+@SuppressWarnings("squid:S106")
 public class SystemPrintLogger implements ILogger {
 
-    private DateFormat format = new SimpleDateFormat("yyyy-MM-dd'T'HH:mm:ssZ");
-
     @Override
     public void finest(String message) {
         System.out.println("FINEST " + message);

src/main/java/org/bitsofinfo/hazelcast/discovery/docker/swarm/test/DockerTestRunner.java

@@ -2,7 +2,6 @@
 
 import com.hazelcast.config.ClasspathXmlConfig;
 import com.hazelcast.config.Config;
-import com.hazelcast.core.HazelcastInstance;
 import com.hazelcast.instance.AddressPicker;
 import com.hazelcast.instance.DefaultNodeContext;
 import com.hazelcast.instance.HazelcastInstanceFactory;
@@ -33,7 +32,7 @@ public AddressPicker createAddressPicker(Node node) {
                 }
             };
 
-            HazelcastInstance hazelcastInstance = HazelcastInstanceFactory
+            HazelcastInstanceFactory
                     .newHazelcastInstance(conf, "hazelcast-docker-swarm-discovery-spi-example", nodeContext);
 
 
@@ -42,16 +41,15 @@ public AddressPicker createAddressPicker(Node node) {
             Config conf = new ClasspathXmlConfig("hazelcast-docker-swarm-discovery-spi-example-member-address-provider.xml");
 
 
-            HazelcastInstance hazelcastInstance = HazelcastInstanceFactory
+            HazelcastInstanceFactory
                     .newHazelcastInstance(conf, "hazelcast-docker-swarm-discovery-spi-example", new DefaultNodeContext());
         } else if (System.getProperty("swarm-bind-method").equalsIgnoreCase("dockerDNSRR")) {
             Config conf =
                     new ClasspathXmlConfig(
                             "hazelcast-docker-swarm-dnsrr-discovery-spi-example.xml"
                     );
 
-            HazelcastInstance hazelcastInstance =
-                    HazelcastInstanceFactory.newHazelcastInstance(conf);
+            HazelcastInstanceFactory.newHazelcastInstance(conf);
         }
 
 

src/main/java/org/bitsofinfo/hazelcast/spi/docker/swarm/dnsrr/DockerDNSRRMemberAddressProvider.java

@@ -38,16 +38,22 @@
  */
 public class DockerDNSRRMemberAddressProvider
         implements MemberAddressProvider {
-    public static Properties properties;
-    public static InetSocketAddress bindAddress = null;
+    protected Properties properties;
+    protected InetSocketAddress bindAddress = null;
     ILogger logger = Logger.getLogger(DockerDNSRRMemberAddressProvider.class);
 
+    /**
+     *
+     * @param properties
+     * @throws NumberFormatException if servicePort cannot be parsed
+     * @throws SocketException
+     * @throws UnknownHostException
+     */
     public DockerDNSRRMemberAddressProvider(Properties properties)
             throws
-            NumberFormatException,
             SocketException,
             UnknownHostException {
-        DockerDNSRRMemberAddressProvider.properties = properties;
+        this.properties = properties;
 
         if (properties != null) {
             String serviceName = properties.getProperty(

src/main/java/org/bitsofinfo/hazelcast/spi/docker/swarm/dnsrr/discovery/DockerDNSRRDiscoveryStrategy.java

@@ -68,10 +68,10 @@ public Iterable<DiscoveryNode> discoverNodes() {
             return discoveryNodes;
         }
 
-        Set<InetAddress> serviceNameResolutions =
-                new HashSet<>();
+        // TODO robin - tighten scope of these variables
+        Set<InetAddress> serviceNameResolutions;
         String[] serviceHostnameAndPort;
-        Integer port = 5701;
+        Integer port;
 
         //Loop for every service defined in the CSV
         for (String service : servicesCsv.split(",")) {