-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AC-1435] Copy updates for Single Organization policy prerequisite for Account Recovery policy #5774
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great from an Auth / Trusted Device Encryption perspective! I pulled down the client and server and tested turning the relevant policies on / off + TDE on / off, and it all functioned as expected!
No New Or Fixed Issues Found |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Created #5790 to resolve the issue of bitwarden_license/bit-web/src/app/auth/*
not having a codeowner.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
43c0b65
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@JaredSnider-Bitwarden @djsmith85 - Had to fix a typo pointed out by QA during testing. I updated the message key to make sure there are no issues with Crowd In. |
Type of change
Objective
Update language related to Single Organization policy requirement for the Account Recovery policy and, by extension, Trusted Device Encryption.
See related server changes that enforce requirements: bitwarden/server#3082
Code changes
FormBuilder
Screenshots
Account Recovery Administration Policy Description Change
Account Recovery Administration Policy Modal Change
SSO TDE Option Description Change
Before you submit