Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend auth ownership #5790

Merged
merged 1 commit into from
Jul 11, 2023
Merged

Extend auth ownership #5790

merged 1 commit into from
Jul 11, 2023

Conversation

djsmith85
Copy link
Contributor

@djsmith85 djsmith85 commented Jul 11, 2023 •
edited
Loading

Type of change

- [ ] Bug fix
- [ ] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [X] Other

Objective

While reviewing #5774 the team-leads-eng got pinged as bitwarden_license/bit-web/src/app/auth/sso/sso.component.html had no codeowner.

Assigning bitwarden_license/bit-web/src/app/auth/ to be owned by @bitwarden/team-auth-dev

Code changes

Extend auth ownership

Before you submit

  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team
  • Ensure that all UI additions follow WCAG AA requirements

@djsmith85
Extend auth ownership
2e44f85 
Assigning `bitwarden_license/bit-web/src/app/auth` @bitwarden/team-auth-dev
@djsmith85 djsmith85 requested a review from a team as a code owner July 11, 2023 15:21
@github-actions github-actions bot added the needs-qa Marks a PR as requiring QA approval label Jul 11, 2023
@djsmith85 djsmith85 mentioned this pull request Jul 11, 2023
Merged
@djsmith85 djsmith85 removed the needs-qa Marks a PR as requiring QA approval label Jul 11, 2023
@djsmith85 djsmith85 enabled auto-merge (squash) July 11, 2023 15:28
@djsmith85 djsmith85 merged commit e2dda66 into master Jul 11, 2023
@djsmith85 djsmith85 deleted the update-codeowners-auth branch July 11, 2023 15:29
@bitwarden-bot
Copy link

Logo
Checkmarx One – Scan Summary & Details – 44ae2e5e-7fbb-4977-bf04-86e8c1ac9cc6

No New Or Fixed Issues Found

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@withinfocus withinfocus withinfocus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@djsmith85 @bitwarden-bot @withinfocus